Bugzilla – Attachment 50812 Details for
Bug 16366
Remove obsolete "border" attribute from <img> tags
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16366 - Remove obsolete "border" attribute from <img> tags
Bug-16366---Remove-obsolete-border-attribute-from-.patch (text/plain), 16.24 KB, created by
Marc Véron
on 2016-04-27 14:42:42 UTC
(
hide
)
Description:
Bug 16366 - Remove obsolete "border" attribute from <img> tags
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2016-04-27 14:42:42 UTC
Size:
16.24 KB
patch
obsolete
>From 3e3aa3df45678a94793f5947f3988fdf6f487ea6 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 27 Apr 2016 09:37:06 -0400 >Subject: [PATCH] Bug 16366 - Remove obsolete "border" attribute from <img> > tags >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch removes the obsolete "border" attribute from <img> tags. >Browsers haven't applied an border to images by default for years. > >There should be no visible changes as a result of this patch. It only >affects HTML validation. If you want to test the affected pages, apply >the patch and confirm that images look correct on these pages: > >- In the patron sidebar menu, if patron images are enabled. >- On the authority MARC subfield structure administration page, only > some obsolete markup is affected (See Bug 16367). >- I don't know how to trigger display of the "filefind.png" image on > authority and bibliographic detail pages. Possibly unused markup? >- On the advanced search page, itemtype/collection/shelving location > images should look correct. >- When viewing existing holds for a title, the arrow images used for > changing the position of a hold in the list should look correct. >- When viewing a list of MARC modification actions, the arrow images > used for changing the order of actions should look correct. > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 4 ++-- > .../prog/en/modules/admin/auth_subfields_structure.tt | 4 ++-- > .../prog/en/modules/authorities/detail.tt | 2 +- > .../prog/en/modules/catalogue/MARCdetail.tt | 2 +- > .../prog/en/modules/catalogue/advsearch.tt | 2 +- > .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++-- > .../intranet-tmpl/prog/en/modules/reserve/request.tt | 16 ++++++++-------- > .../en/modules/tools/marc_modification_templates.tt | 8 ++++---- > 8 files changed, 21 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >index f545afa..cc43860 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >@@ -8,9 +8,9 @@ > <ul class="patronbriefinfo"> > [% IF ( patronimages ) %] > [% IF ( picture ) %] >- <li><img src="/cgi-bin/koha/members/patronimage.pl?borrowernumber=[% borrowernumber | uri %]" id="patronimage" alt="[% firstname %] [% surname %] ([% cardnumber %])" border="0" style="max-width : 140px; margin: .3em 0 .3em .3em; padding: .2em; border: 1px solid #CCCCCC; width:auto !important; width:130px;" /></li> >+ <li><img src="/cgi-bin/koha/members/patronimage.pl?borrowernumber=[% borrowernumber | uri %]" id="patronimage" alt="[% firstname %] [% surname %] ([% cardnumber %])" style="max-width : 140px; margin: .3em 0 .3em .3em; padding: .2em; border: 1px solid #CCCCCC; width:auto !important; width:130px;" /></li> > [% ELSE %] >- <li id="patronbasics"><img src="[% interface %]/[% theme %]/img/patron-blank.png" alt="[% firstname %] [% surname %] ([% cardnumber %])" border="0" style="margin: .3em 0 .3em .3em; padding: .2em; border: 1px solid #CCCCCC;" /></li> >+ <li id="patronbasics"><img src="[% interface %]/[% theme %]/img/patron-blank.png" alt="[% firstname %] [% surname %] ([% cardnumber %])" style="margin: .3em 0 .3em .3em; padding: .2em; border: 1px solid #CCCCCC;" /></li> > [% END %] > [% END %] > [% IF Koha.Preference( 'AddressFormat' ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >index 7caceca..66045a8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >@@ -321,12 +321,12 @@ > </form> > > [% IF ( previous ) %] >- <input type="image" src="[% interface %]/[% theme %]/images/1leftarrow.png" title="previous" alt="previous" border="0" /> >+ <input type="image" src="[% interface %]/[% theme %]/images/1leftarrow.png" title="previous" alt="previous" /> > </a> > [% END %] > [% IF ( next ) %] > [% next %] >- <input type="image" src="[% interface %]/[% theme %]/images/1rightarrow.png" title="next" alt="next" border="0" /> >+ <input type="image" src="[% interface %]/[% theme %]/images/1rightarrow.png" title="next" alt="next" /> > </a> > [% END %] > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >index 3b7f262..295c325 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >@@ -125,7 +125,7 @@ function searchauthority() { > [% subfiel.marc_value %] > [% IF ( subfiel.link ) %] > <a href="/cgi-bin/koha/catalogue/search.pl?op=do_search&marclist=[% subfiel.link %]&operator==&type=intranet&value=[% subfiel.marc_value |url %]"> >- <img border="0" src="[% interface %]/[% theme %]/images/filefind.png" height="15" title="Search on [% subfiel.marc_value %]"> >+ <img src="[% interface %]/[% theme %]/images/filefind.png" height="15" title="Search on [% subfiel.marc_value %]"> > </a> > [% END %] > [% IF ( subfiel.authority ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >index 4c0c115..992bd0a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >@@ -93,7 +93,7 @@ function Changefwk(FwkList) { > [% IF ( subfiel.is_url ) %]<a href="[% subfiel.marc_value %]">[% subfiel.marc_value |html %]</a>[% ELSE %][% subfiel.marc_value |html %][% END %] > [% IF ( subfiel.link ) %] > <a href="/cgi-bin/koha/catalogue/search.pl?op=do_search&idx=[% subfiel.link %],phr&type=intranet&q=[% subfiel.marc_value |url %]"> >- <img border="0" src="[% interface %]/[% theme %]/img/filefind.png" height="15" title="Search on [% subfiel.marc_value |html %]" alt="Search on [% subfiel.marc_value |html %]" /> >+ <img src="[% interface %]/[% theme %]/img/filefind.png" height="15" title="Search on [% subfiel.marc_value |html %]" alt="Search on [% subfiel.marc_value |html %]" /> > </a> > [% END %] > [% IF ( subfiel.authority ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >index e2bd3cc..ebf878a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >@@ -117,7 +117,7 @@ > <table> > <tr> > [% FOREACH itemtypeloo IN advsearchloo.code_loop %] >- <td><input type="checkbox" id="[% itemtypeloo.ccl FILTER remove(',') %]-[% itemtypeloo.number %]" name="limit" value="mc-[% itemtypeloo.ccl %]:[% itemtypeloo.code %]"/><label for="[% itemtypeloo.ccl FILTER remove(',') %]-[% itemtypeloo.number %]">[% UNLESS ( noItemTypeImages ) %][% IF ( itemtypeloo.imageurl ) %]<img border="0" src="[% itemtypeloo.imageurl %]" alt="[% itemtypeloo.description %]" />[% END %] [% END %] >+ <td><input type="checkbox" id="[% itemtypeloo.ccl FILTER remove(',') %]-[% itemtypeloo.number %]" name="limit" value="mc-[% itemtypeloo.ccl %]:[% itemtypeloo.code %]"/><label for="[% itemtypeloo.ccl FILTER remove(',') %]-[% itemtypeloo.number %]">[% UNLESS ( noItemTypeImages ) %][% IF ( itemtypeloo.imageurl ) %]<img src="[% itemtypeloo.imageurl %]" alt="[% itemtypeloo.description %]" />[% END %] [% END %] > [% itemtypeloo.description %]</label></td> > [% IF ( loop.last ) %]</tr>[% ELSE %][% UNLESS ( loop.count % 5 ) %]</tr><tr>[% END %][% END %] > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index e314fa1..24fde0c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -387,7 +387,7 @@ function verify_images() { > [% IF ( AmazonCoverImages ) %] > <div id="amazon-bookcoverimg"> > <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"> >- <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> >+ <img src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> > </a></div> > [% END %] > [% END %] >@@ -461,7 +461,7 @@ function verify_images() { > [% IF ( AmazonCoverImages ) %] > <div id="amazon-bookcoverimg"> > <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"> >- <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> >+ <img src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> > </a> > </div> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 473cfb4..7a73571 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -677,7 +677,7 @@ function checkMultiHold() { > <th>Pickup library</th> > <th>Details</th> > [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] >- <th><img src="[% interface %]/[% theme %]/img/go-bottom.png" border="0" alt="Toggle set to lowest priority" /></th> >+ <th><img src="[% interface %]/[% theme %]/img/go-bottom.png" alt="Toggle set to lowest priority" /></th> > [% END %] > <th> </th> > [% IF SuspendHoldsIntranet %]<th> </th><!-- Suspend Holds Column Header -->[% END %] >@@ -715,19 +715,19 @@ function checkMultiHold() { > [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] > <td style="white-space:nowrap;"> > <a title="Move hold up" href="request.pl?action=move&where=up&borrowernumber=[% reserveloo.borrowernumber %]&biblionumber=[% reserveloo.biblionumber %]&reserve_id=[% reserveloo.reserve_id %]&date=[% reserveloo.date %]"> >- <img src="[% interface %]/[% theme %]/img/go-up.png" border="0" alt="Go up" /> >+ <img src="[% interface %]/[% theme %]/img/go-up.png" alt="Go up" /> > </a> > > <a title="Move hold to top" href="request.pl?action=move&where=top&borrowernumber=[% reserveloo.borrowernumber %]&biblionumber=[% reserveloo.biblionumber %]&reserve_id=[% reserveloo.reserve_id %]&date=[% reserveloo.date %]"> >- <img src="[% interface %]/[% theme %]/img/go-top.png" border="0" alt="Go top" /> >+ <img src="[% interface %]/[% theme %]/img/go-top.png" alt="Go top" /> > </a> > > <a title="Move hold to bottom" href="request.pl?action=move&where=bottom&borrowernumber=[% reserveloo.borrowernumber %]&biblionumber=[% reserveloo.biblionumber %]&reserve_id=[% reserveloo.reserve_id %]&date=[% reserveloo.date %]"> >- <img src="[% interface %]/[% theme %]/img/go-bottom.png" border="0" alt="Go bottom" /> >+ <img src="[% interface %]/[% theme %]/img/go-bottom.png" alt="Go bottom" /> > </a> > > <a title="Move hold down" href="request.pl?action=move&where=down&borrowernumber=[% reserveloo.borrowernumber %]&biblionumber=[% reserveloo.biblionumber %]&reserve_id=[% reserveloo.reserve_id %]&date=[% reserveloo.date %]"> >- <img src="[% interface %]/[% theme %]/img/go-down.png" border="0" alt="Go down" /> >+ <img src="[% interface %]/[% theme %]/img/go-down.png" alt="Go down" /> > </a> > </td> > [% END %] >@@ -808,9 +808,9 @@ function checkMultiHold() { > <td> > <a title="Toggle lowest priority" href="request.pl?action=setLowestPriority&borrowernumber=[% reserveloo.borrowernumber %]&biblionumber=[% reserveloo.biblionumber %]&reserve_id=[% reserveloo.reserve_id %]&date=[% reserveloo.date %]"> > [% IF ( reserveloo.lowestPriority ) %] >- <img src="[% interface %]/[% theme %]/img/go-bottom.png" border="0" alt="Unset lowest priority" /> >+ <img src="[% interface %]/[% theme %]/img/go-bottom.png" alt="Unset lowest priority" /> > [% ELSE %] >- <img src="[% interface %]/[% theme %]/img/go-down.png" border="0" alt="Set to lowest priority" /> >+ <img src="[% interface %]/[% theme %]/img/go-down.png" alt="Set to lowest priority" /> > [% END %] > </a> > </td> >@@ -818,7 +818,7 @@ function checkMultiHold() { > > <td> > <a title="Cancel hold" href="request.pl?action=cancel&borrowernumber=[% reserveloo.borrowernumber %]&biblionumber=[% reserveloo.biblionumber %]&reserve_id=[% reserveloo.reserve_id %]&date=[% reserveloo.date %]"> >- <img src="[% interface %]/[% theme %]/img/x.png" border="0" alt="Cancel" /> >+ <img src="[% interface %]/[% theme %]/img/x.png" alt="Cancel" /> > </a> > </td> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >index 1086670..c7a1b2b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >@@ -79,19 +79,19 @@ > <tr> > <td style="white-space:nowrap;"> > <a title="Move action up" href="marc_modification_templates.pl?op=move_action&where=up&template_id=[% ActionsLoo.template_id %]&mmta_id=[% ActionsLoo.mmta_id %]"> >- <img src="[% interface %]/[% theme %]/img/go-up.png" border="0" alt="Go up" /> >+ <img src="[% interface %]/[% theme %]/img/go-up.png" alt="Go up" /> > </a> > > <a title="Move action to top" href="marc_modification_templates.pl?op=move_action&where=top&template_id=[% ActionsLoo.template_id %]&mmta_id=[% ActionsLoo.mmta_id %]"> >- <img src="[% interface %]/[% theme %]/img/go-top.png" border="0" alt="Go top" /> >+ <img src="[% interface %]/[% theme %]/img/go-top.png" alt="Go top" /> > </a> > > <a title="Move action to bottom" href="marc_modification_templates.pl?op=move_action&where=bottom&template_id=[% ActionsLoo.template_id %]&mmta_id=[% ActionsLoo.mmta_id %]"> >- <img src="[% interface %]/[% theme %]/img/go-bottom.png" border="0" alt="Go bottom" /> >+ <img src="[% interface %]/[% theme %]/img/go-bottom.png" alt="Go bottom" /> > </a> > > <a title="Move action down" href="marc_modification_templates.pl?op=move_action&where=down&template_id=[% ActionsLoo.template_id %]&mmta_id=[% ActionsLoo.mmta_id %]"> >- <img src="[% interface %]/[% theme %]/img/go-down.png" border="0" alt="Go down" /> >+ <img src="[% interface %]/[% theme %]/img/go-down.png" alt="Go down" /> > </a> > </td> > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16366
:
50810
|
50812
|
50833