Bug 16366 - Remove obsolete "border" attribute from <img> tags
Summary: Remove obsolete "border" attribute from <img> tags
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-27 13:31 UTC by Owen Leonard
Modified: 2016-12-05 21:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16366 - Remove obsolete "border" attribute from <img> tags (16.15 KB, patch)
2016-04-27 14:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16366 - Remove obsolete "border" attribute from <img> tags (16.24 KB, patch)
2016-04-27 14:42 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16366 - Remove obsolete "border" attribute from <img> tags (16.31 KB, patch)
2016-04-27 16:50 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-04-27 13:31:14 UTC
There are many instances in the staff client templates where a border attribute is applied to an <img> tag. The border attribute is obsolete and unnecessary and can be removed.
Comment 1 Owen Leonard 2016-04-27 14:18:24 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-27 14:41:53 UTC
Testing...

- In the patron sidebar menu, if patron images are enabled.
OK
- On the authority MARC subfield structure administration page, only
  some obsolete markup is affected (See Bug 16367).
OK (compared code in diff)
- I don't know how to trigger display of the "filefind.png" image on
  authority and bibliographic detail pages. Possibly unused markup?
OK (compared code in diff)
- On the advanced search page, itemtype/collection/shelving location
  images should look correct.
OK
- When viewing existing holds for a title, the arrow images used for
  changing the position of a hold in the list should look correct.
OK
- When viewing a list of MARC modification actions, the arrow images
  used for changing the order of actions should look correct.
OK
Comment 3 Marc Véron 2016-04-27 14:42:42 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2016-04-27 16:50:04 UTC
Created attachment 50833 [details] [review]
[PASSED QA] Bug 16366 - Remove obsolete "border" attribute from <img> tags

This patch removes the obsolete "border" attribute from <img> tags.
Browsers haven't applied an border to images by default for years.

There should be no visible changes as a result of this patch. It only
affects HTML validation. If you want to test the affected pages, apply
the patch and confirm that images look correct on these pages:

- In the patron sidebar menu, if patron images are enabled.
- On the authority MARC subfield structure administration page, only
  some obsolete markup is affected (See Bug 16367).
- I don't know how to trigger display of the "filefind.png" image on
  authority and bibliographic detail pages. Possibly unused markup?
- On the advanced search page, itemtype/collection/shelving location
  images should look correct.
- When viewing existing holds for a title, the arrow images used for
  changing the position of a hold in the list should look correct.
- When viewing a list of MARC modification actions, the arrow images
  used for changing the order of actions should look correct.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Kyle M Hall 2016-04-29 16:15:16 UTC
Pushed to master for the 16.05 release. Thanks Owen!