Bugzilla – Attachment 51310 Details for
Bug 16412
Cache undef in L1 only
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 16412: Make sure Koha::Cache->set_in_cache will not warn anymore
PASSED-QA-Bug-16412-Make-sure-KohaCache-setincache.patch (text/plain), 1.24 KB, created by
Katrin Fischer
on 2016-05-08 14:34:42 UTC
(
hide
)
Description:
[PASSED QA] Bug 16412: Make sure Koha::Cache->set_in_cache will not warn anymore
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-05-08 14:34:42 UTC
Size:
1.24 KB
patch
obsolete
>From 879caea2fc3aac850758dbb3a811308b57c7b574 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 2 May 2016 12:39:29 +0100 >Subject: [PATCH] [PASSED QA] Bug 16412: Make sure Koha::Cache->set_in_cache > will not warn anymore > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/Cache.t | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > >diff --git a/t/Cache.t b/t/Cache.t >index 5a5c248..101f723 100644 >--- a/t/Cache.t >+++ b/t/Cache.t >@@ -17,7 +17,8 @@ > > use Modern::Perl; > >-use Test::More tests => 40; >+use Test::More tests => 41; >+use Test::Warn; > > my $destructorcount = 0; > >@@ -40,6 +41,16 @@ SKIP: { > is( $cache->get_from_cache("not in here"), > undef, "fetching item NOT in cache" ); > >+ # set_in_cache should not warn >+ my $warn; >+ { >+ local $SIG{__WARN__} = sub { >+ $warn = shift; >+ }; >+ $cache->set_in_cache( "a key", undef ); >+ is( $warn, undef, 'Koha::Cache->set_in_cache should not return any warns' ); >+ } >+ > # test expiry time in cache > $cache->set_in_cache( "timeout", "I AM DATA", 1 ); # expiry time of 1 second > sleep 2; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16412
:
51086
|
51089
|
51090
| 51310 |
51311