No need to cache undef in L2. Prevent numerous warnings like: Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284
Created attachment 51086 [details] [review] Bug 16412: Cache undef in L1 only No need to cache undef in L2. Prevent numerous warnings like: Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284 Test plan: Run t/Cache.t Run t/db_dependent/sysprefs.t
Created attachment 51089 [details] [review] Bug 16412: Make sure Koha::Cache->set_in_cache will not warn anymore Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 51090 [details] [review] Bug 16412: Cache undef in L1 only No need to cache undef in L2. Prevent numerous warnings like: Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284 Test plan: Run t/Cache.t Run t/db_dependent/sysprefs.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: remove trailing space char and replace 'you' with 'we' to match existing wordings.
Thanks, Jonathan. Just to clarify for QA: If you use memcached, this patch will remove numerous warnings like: Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284
Created attachment 51310 [details] [review] [PASSED QA] Bug 16412: Make sure Koha::Cache->set_in_cache will not warn anymore Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 51311 [details] [review] [PASSED QA] Bug 16412: Cache undef in L1 only No need to cache undef in L2. Prevent numerous warnings like: Use of uninitialized value in subroutine entry at /usr/share/koha/masterclone/Koha/Cache.pm line 284 Test plan: Run t/Cache.t Run t/db_dependent/sysprefs.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: remove trailing space char and replace 'you' with 'we' to match existing wordings. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed for inclusion in 16.05, to be released in May 2015. Thanks for your work!
May 2016, rather...
Not needed in stable versions, status changed to RESOLVED
(In reply to Julian Maurice from comment #9) > Not needed in stable versions, status changed to RESOLVED Now needed because bug 16044 was pushed to 3.22.x Patches pushed to 3.22.x, will be in 3.22.8