Bugzilla – Attachment 5253 Details for
Bug 6829
Remove two warnings for opac-MARCdetail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
patch.txt (text/plain), 6.62 KB, created by
Marcel de Rooy
on 2011-09-01 12:36:59 UTC
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2011-09-01 12:36:59 UTC
Size:
6.62 KB
patch
obsolete
>From d40105cae49a8b8f6cff37d693169f3449543044 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 1 Sep 2011 11:53:16 +0200 >Subject: [PATCH] 6278 Funny translation bug with XSLT subfieldSelect parameters >Content-Type: text/plain; charset="utf-8" > >This patch resolves the situation of translating the parameters at (meaning subfield a and t) of subfieldSelect by replacing at with a_t. This string will not be translated and the xslt function subfieldSelect just ignores the underscore. >It is a pragmatic and easy solution. Theoretically, we should look for a solution in the translation parser. This is much harder and would probably not result in better code in those modules. > >Test this patch with the following remarks in mind: >1) This patch deals with XSLT. So you should enable XSLT at OPAC detail. >2) In English or any language not translating the word at: Just check if the links for a MARC 490, 773, 780 or 785 still work at the opac detail page. >3) For a language translating the word at (like Dutch where at becomes bij), you should first rerun your translation process (at least for the OPAC). >4) In that language: Check the results on the vernacular opac detail page for MARC 490, 773, 780 or 785. Without the patch, you would not see a link following e.g. the Series label (with 490 first indicator set to 1). With the patch, you should see a link now. >--- > .../prog/en/xslt/MARC21slim2OPACDetail.xsl | 10 +++++----- > .../prog/en/xslt/NORMARCslim2OPACDetail.xsl | 4 ++-- > .../prog/en/xslt/UNIMARCslim2OPACDetail.xsl | 4 ++-- > 3 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >index d4f763f..a0b72de 100755 >--- a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >@@ -246,7 +246,7 @@ > <xsl:call-template name="chopPunctuation"> > <xsl:with-param name="chopString"> > <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">at</xsl:with-param> >+ <xsl:with-param name="codes">a_t</xsl:with-param> > </xsl:call-template> > </xsl:with-param> > </xsl:call-template> >@@ -257,7 +257,7 @@ > <xsl:call-template name="chopPunctuation"> > <xsl:with-param name="chopString"> > <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">at</xsl:with-param> >+ <xsl:with-param name="codes">a_t</xsl:with-param> > </xsl:call-template> > </xsl:with-param> > </xsl:call-template> >@@ -668,7 +668,7 @@ > </span> > <xsl:variable name="f773"> > <xsl:call-template name="chopPunctuation"><xsl:with-param name="chopString"><xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">at</xsl:with-param> >+ <xsl:with-param name="codes">a_t</xsl:with-param> > </xsl:call-template></xsl:with-param></xsl:call-template> > </xsl:variable> > <xsl:choose> >@@ -786,7 +786,7 @@ > </xsl:choose> > <xsl:variable name="f780"> > <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">at</xsl:with-param> >+ <xsl:with-param name="codes">a_t</xsl:with-param> > </xsl:call-template> > </xsl:variable> > <xsl:choose> >@@ -848,7 +848,7 @@ > </xsl:choose> > <xsl:variable name="f785"> > <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">at</xsl:with-param> >+ <xsl:with-param name="codes">a_t</xsl:with-param> > </xsl:call-template> > </xsl:variable> > >diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl >index 961f0c9..d2b6b1b 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl >@@ -419,7 +419,7 @@ > </span> > <xsl:variable name="f780"> > <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">at</xsl:with-param> >+ <xsl:with-param name="codes">a_t</xsl:with-param> > </xsl:call-template> > </xsl:variable> > <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=<xsl:value-of select="translate($f780, '()', '')"/></xsl:attribute> >@@ -469,7 +469,7 @@ > </span> > <xsl:variable name="f785"> > <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">at</xsl:with-param> >+ <xsl:with-param name="codes">a_t</xsl:with-param> > </xsl:call-template> > </xsl:variable> > >diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl >index 2832b6b..61054ea 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl >@@ -411,7 +411,7 @@ > </xsl:choose> > <xsl:variable name="f780"> > <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">at</xsl:with-param> >+ <xsl:with-param name="codes">a_t</xsl:with-param> > </xsl:call-template> > </xsl:variable> > <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=<xsl:value-of select="translate($f780, '()', '')"/></xsl:attribute> >@@ -464,7 +464,7 @@ > </xsl:choose> > <xsl:variable name="f785"> > <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">at</xsl:with-param> >+ <xsl:with-param name="codes">a_t</xsl:with-param> > </xsl:call-template> > </xsl:variable> > >-- >1.6.0.6 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6829
:
5253
|
5254
|
5255
|
5256
|
5257
|
6931
|
7035
|
7051