Remove this warning by adding a check: [Thu Sep 01 14:20:18 2011] [error] [client 192.87.126.61] [Thu Sep 1 14:20:18 2011] opac-MARCdetail.pl: Use of uninitialized value in string ne at /usr/share/koha/testclone/opac/opac-MARCdetail.pl line 145., referer: http://libdevelop.rijksmuseum.nl:8008/cgi-bin/koha/opac-detail.pl?biblionumber=144200 And this warning: [Mon Aug 29 13:58:02 2011] [error] [client 66.249.72.86] [Mon Aug 29 13:58:02 2011] opac-MARCdetail.pl: Use of uninitialized value in string comparison (cmp) at /usr/share/koha/prodclone/opac/opac-MARCdetail.pl line 238. This warning is still generated in 3.3.0.12, but could be resolved in 3.5 with the removing of 952 from marcxml. The check does not hurt however.
Created attachment 5253 [details] [review] Patch
Created attachment 5254 [details] [review] Patch Oops. Submitted the wrong file.
Test: Check your logfile for the error on line 145. After you applied the patch, run opac-MARCdetail again for that record; you should not receive the warning again in the logfile for that biblionumber.
Still getting one error in the log: opac-MARCdetail.pl: Use of uninitialized value in string ne at /kohaclone/opac/opac-MARCdetail.pl line 218.
Created attachment 5255 [details] [review] Revised patch Clearing warning from Owen too.
Created attachment 5256 [details] [review] Revised patch improved
Created attachment 5257 [details] [review] Signed-off patch
Simple fix to remove warns, pushed
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.
With this patch, opac-MARCdetail.pl doesn't display anymore subfields which 'hidden' parameter is set to 0. Reverting this patch solves the issue. But I will send a follow-up patch.
Created attachment 6931 [details] [review] Follow up patch To reproduce the bug: - Open OPAC MARC View for a specific biblio record - Fields which are affected to tab 0 are all hidden
Created attachment 7035 [details] [review] [SIGNED-OFF] Bug 6829 Follow up patch To reproduce the bug: - Open OPAC MARC View for a specific biblio record - Fields which are affected to tab 0 are all hidden Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes bug for 0xx fields in OPAC MARC view. Note: the problem only exists for 0xx fields with real subfields, control fields display correctly, fields like 040 only display after patch was applied.
Simple one line change, replacing a '' with 0 (which is more explicitly correct in this case) and ne with !=. Marking as Passed QA
(In reply to comment #13) > Simple one line change, replacing a '' with 0 (which is more explicitly correct > in this case) and ne with !=. Marking as Passed QA There is still a possible issue here (a 952 subfield). Was just looking at it.
Created attachment 7051 [details] [review] Second follow up Needed this second follow up to remove 952-0 from the display again, coming up after the first follow up. Changed a second test in accordance with first follow up. Removed a useless 10th loop to create a tab10XX that is not in the template. Took the liberty to sign it off myself. Small change but annoying to find.
Ian, If you could have a second look please. Thanks and sorry for the inconvenience..
Followup patch is straightforward change to loop size, and uses 'defined' versus variable evaluation to handle 0 case. Marking as Passed QA