Bugzilla – Attachment 6690 Details for
Bug 7338
link to serial detail wrong
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-Bug-7338-Links-on-Serial-Collection-page.patch (text/plain), 2.82 KB, created by
Frédéric Demians
on 2011-12-09 07:35:27 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2011-12-09 07:35:27 UTC
Size:
2.82 KB
patch
obsolete
>From 5ed9e4f1a4c218adc6243e68434a976201eda7b6 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Fri, 9 Dec 2011 08:32:01 +0100 >Subject: [PATCH] Bug 7338 Links on Serial Collection page > >Don't display link to the serial, when the collection page displays just >one subscription. Display it when several subscriptions. Alway display a >link for displaying biblio record other subscriptions. >--- > .../prog/en/modules/serials/serials-collection.tt | 11 +++++------ > serials/serials-collection.pl | 1 - > 2 files changed, 5 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >index 93c4fdc..ed126af 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >@@ -71,7 +71,7 @@ $(document).ready(function() { > > [% IF ( subscriptions ) %] > <table> >-[% IF ( onesubscription ) %] >+[% IF ( subscriptions.size == 1 ) %] > <caption> Subscription Summary</caption> > [% ELSE %] > <caption> Subscription Summaries</caption> >@@ -161,9 +161,8 @@ $(document).ready(function() { > </tr> > [% END %] > [% IF ( subscr ) %] >-[% UNLESS ( onesubscription ) %] >-<tr ><td colspan="7"> <a href="serials-collection.pl?biblionumber=[% biblionumber %]">See any subscription attached to this biblio</a></td> >-</tr>[% END %] >+<tr ><td colspan="8"> <a href="serials-collection.pl?biblionumber=[% biblionumber %]">See any subscription attached to this biblio</a></td> >+</tr> > [% END %] > </table> > [% END %] >@@ -183,7 +182,7 @@ $(document).ready(function() { > <div id="subscription-year-[% year.year %]"> > <table> > <tr> >-[% UNLESS ( year.onesubscription ) %] >+[% IF ( subscriptions.size > 1 ) %] > <th># Subs</th> > [% END %] > <th>Date published >@@ -205,7 +204,7 @@ $(document).ready(function() { > </tr> > [% FOREACH serial IN year.serials %] > [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >-[% UNLESS ( serial.onesubscription ) %] >+[% IF ( subscriptions.size > 1 ) %] > <td><a href="serials-collection.pl?subscriptionid=[% serial.subscriptionid %]">[% serial.subscriptionid %]</a></td> > [% END %] > <td> >diff --git a/serials/serials-collection.pl b/serials/serials-collection.pl >index 8c7c32b..c4605e0 100755 >--- a/serials/serials-collection.pl >+++ b/serials/serials-collection.pl >@@ -147,7 +147,6 @@ foreach (@$location) { > > chop $subscriptionidlist; > $template->param( >- onesubscription => (scalar(@$subscriptiondescs)==1), > subscriptionidlist => $subscriptionidlist, > biblionumber => $biblionumber, > subscriptions => $subscriptiondescs, >-- >1.7.8 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7338
:
6672
|
6688
|
6689
|
6690
|
6695
|
6713
|
6717
|
6733