Created attachment 6672 [details] subscription # links When on this page: /cgi-bin/koha/serials/serials-collection.pl?subscriptionid=5427 if you click the serial # at the top it takes you to the detail which I think is right. But if you click the serial # next to the issue history it just refreshes the page you're on.
Created attachment 6688 [details] screenshot of record with more than 1 subscription and manipulated URL It's a scoping problem, but I made an interesting find: http://localhost:8080/cgi-bin/koha/serials/serials-collection.pl?biblionumber=1 If you have more than one subscription for that record and you add the biblionumber of the subscription to the URL instead of the subscriptionid, you get an overview of your entire serial collection for that record. Why do we never link this page like this? Am I missing something? Will send a patch to fix the scoping problem.
Created attachment 6689 [details] [review] Bug 7338: Link on serial collection page wrong This was a scoping error. The links are not supposed to show up when you open that page with a subscription id in the URL. To test: 1) Check links don't show up now.
Created attachment 6690 [details] [review] Proposed patch
Why are there two patches? I'm going to test the first one which was Katrin's
Created attachment 6695 [details] [review] [SIGNED-OFF] Bug 7338: Link on serial collection page wrong This was a scoping error. The links are not supposed to show up when you open that page with a subscription id in the URL. To test: 1) Check links don't show up now. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed off on Katrin's patch. Please let me know what the second patch was for.
I think Frederic and me discovered a hidden feature while trying to fix this bug. I will try to investigate / test it a bit more this weekend.
Created attachment 6713 [details] [review] Bug 7338: Follow up: show link only when there is more than 1 subscription To be tested together with http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6690 1) Create a subscription for a title - check the link 'Show any subscription...' doesn't show now - check the serials collection page works correctly and shows all necessary information 2) Create a second subscription for the same title - check a new link 'Show any subscription...' shows up now - use links in the issue table to change between viewing the single subscription and the overview page - check it works correctly and all information shows up
Hi Nicole, sorry for causing confusion and thx for your sign-off. Could you take a look at those both patches together? It should make available some nice new functionality for records with more than 1 subscription!
Created attachment 6717 [details] [review] Signed-off follow-up patch It works. With this patch, on Serials Collection page, the link, 'See any subscription attached to this biblio' appears only when there are more than one subscription attached to the biblio record. Kait: You haven't attach my patch with your sign-off.
Hi Frederic, thx for signing off. Your patch works great as well - I will replace the attached patch with a signed off one tonight.
Created attachment 6733 [details] [review] [SIGNED-OFF] Bug 7338 Links on Serial Collection page Don't display link to the serial, when the collection page displays just one subscription. Display it when several subscriptions. Alway display a link for displaying biblio record other subscriptions. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely, but always shows link to 'any subscriptions'. I did a follow-up so the link would only show if there was more than 1 subscription for the record.
Works as advertised, template-based change (with a bit of logic in the script to send new param values). Patches must be applied in REVERSE ORDER than currently listed. Passed QA
patch pushed please test: QA comment: prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok