Bugzilla – Attachment 71617 Details for
Bug 20197
Missing rfc3339 in systempreference choices for dateformat
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20197: RFC3339 missing from options
Bug-20197-RFC3339-missing-from-options.patch (text/plain), 4.15 KB, created by
Mark Tompsett
on 2018-02-14 15:53:40 UTC
(
hide
)
Description:
Bug 20197: RFC3339 missing from options
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2018-02-14 15:53:40 UTC
Size:
4.15 KB
patch
obsolete
>From 52892aabe777679340375b6466bd1b7715167c18 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 14 Feb 2018 15:41:26 +0000 >Subject: [PATCH] Bug 20197: RFC3339 missing from options > >The output_pref in Koha::DateUtils has rfc3339 logic, but >there is no way to set the system preference to rfc3339. >This adds that option. > >TEST PLAN >---------- >0) back up your DB if you wish. >1) apply this patch. >2) Run the following commands: > $ mysql -u koha_kohadev -p > > use koha_kohadev; > > SELECT options FROM systempreferences WHERE variable='dateformat'; > -- no rfc3339 listed. >3) Run the following commands: > > quit > $ updatedatabase > $ mysql -u koha_kohadev -p > > use koha_kohadev; > > SELECT options FROM systempreferences WHERE variable='dateformat'; > -- rfc3339 now listed. >4) Run the following commands: > > quit > $ reset_all > $ mysql -u koha_kohadev -p > > use koha_kohadev; > > SELECT options FROM systempreferences WHERE variable='dateformat'; > -- rfc3339 still listed. >5) Log into the staff client >6) Home -> Administration -> Global System Preferences -> i18n/l10n > -- rfc3339 should be listed in the dateformat syspref drop-down. >7) run koha qa test tools >8) restore DB if needed >--- > installer/data/mysql/atomicupdate/bug_20197.sql | 1 + > installer/data/mysql/sysprefs.sql | 2 +- > .../intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref | 2 ++ > 3 files changed, 4 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_20197.sql > >diff --git a/installer/data/mysql/atomicupdate/bug_20197.sql b/installer/data/mysql/atomicupdate/bug_20197.sql >new file mode 100644 >index 0000000..2c2b771 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_20197.sql >@@ -0,0 +1 @@ >+UPDATE systempreferences SET options='metric|us|iso|dmydot|rfc3339' WHERE variable='dateformat'; >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 68881d0..425df82 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -116,7 +116,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('CronjobLog','0',NULL,'If ON, log information from cron jobs.','YesNo'), > ('CumulativeRestrictionPeriods',0,NULL,'Cumulate the restriction periods instead of keeping the highest','YesNo'), > ('CurrencyFormat','US','US|FR|CH','Determines the display format of currencies. eg: \'36000\' is displayed as \'360 000,00\' in \'FR\' or \'360,000.00\' in \'US\'.','Choice'), >-('dateformat','us','metric|us|iso|dmydot','Define global date format (us mm/dd/yyyy, metric dd/mm/yyy, ISO yyyy-mm-dd, dmydot dd.mm.yyyy)','Choice'), >+('dateformat','us','metric|us|iso|dmydot|rfc3339','Define global date format (us mm/dd/yyyy, metric dd/mm/yyy, ISO yyyy-mm-dd [24 hour only] , dmydot dd.mm.yyyy, rfc3339 yyyy-mm-dd)','Choice'), > ('DebugLevel','2','0|1|2','Define the level of debugging information sent to the browser when errors are encountered (set to 0 in production). 0=none, 1=some, 2=most','Choice'), > ('decreaseLoanHighHolds',NULL,'','Decreases the loan period for items with number of holds above the threshold specified in decreaseLoanHighHoldsValue','YesNo'), > ('decreaseLoanHighHoldsControl', 'static', 'static|dynamic', "Chooses between static and dynamic high holds checking", 'Choice'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref >index f7f4252..82eab3c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref >@@ -8,7 +8,9 @@ I18N/L10N: > metric: dd/mm/yyyy > dmydot: dd.mm.yyyy > iso: yyyy-mm-dd >+ rfc3339: yyyy-mm-dd > - . <b>Note:</b> Do not change this preference on a production server with overdue items that are accruing fines. Doing so will result in duplicate fines! >+ - . ISO dateformats should be 24 hour time formats only. > - > - Format times in > - pref: TimeFormat >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20197
:
71617
|
75577