Bugzilla – Attachment 76417 Details for
Bug 10348
Show number of items on tab headings in the staff client
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10348: Show number of items on tab headings in the staff client
Bug-10348-Show-number-of-items-on-tab-headings-in-.patch (text/plain), 3.10 KB, created by
Owen Leonard
on 2018-06-25 20:11:13 UTC
(
hide
)
Description:
Bug 10348: Show number of items on tab headings in the staff client
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2018-06-25 20:11:13 UTC
Size:
3.10 KB
patch
obsolete
>From 6ad8eac88dd88dea1aa5e24f345379d405cd45a3 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 25 Jun 2018 15:55:03 -0400 >Subject: [PATCH] Bug 10348: Show number of items on tab headings in the staff > client > >This patch uses Template Toolkit's size() method to add a count to >the bibliographic detail page's holdings and images tabs. > >To test, apply the patch and view the detail page for a record in >the staff client. Check under the following conditions: > >- The SeparateHoldings system preference is set to "Don't separate" > - The holdings tab should show the correct item count. >- The SeparateHoldings system preference is set to "Separate" > - The "[Library] holdings" tab and "Other holdings" tabs should > have the correct item counts. >- With LocalCoverImages enabled the "Images" tab should show the > correct count of attached images. Test with zero or more attached > images. >--- > .../prog/en/modules/catalogue/detail.tt | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index ec6695c..e6361be 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -292,16 +292,28 @@ > > <ul> > [% IF (SeparateHoldings) %] >- <li><a href="#holdings">[% LoginBranchname %] holdings</a></li> >- <li><a href="#otherholdings">Other holdings</a></li> >+ <li> >+ <a href="#holdings">[% LoginBranchname %] holdings ([% itemloop.size() || 0 %])</a> >+ </li> >+ <li> >+ <a href="#otherholdings">Other holdings ([% otheritemloop.size() || 0 %])</a> >+ </li> > [% ELSE %] >- <li><a href="#holdings">Holdings</a></li> >+ <li> >+ <a href="#holdings">Holdings ([% itemloop.size() || 0 %])</a> >+ </li> > [% END %] > [% IF ( MARCNOTES || notes ) %]<li><a href="#description">Descriptions</a></li>[% END %] > [% IF ( subscriptionsnumber ) %]<li><a href="#subscriptions">Subscriptions</a></li>[% END %] > [% IF Koha.Preference('AcquisitionDetails') %]<li><a href="#acq_details">Acquisition details</a></li>[% END %] > [% IF ( FRBRizeEditions ) %][% IF ( XISBNS ) %]<li><a href="#editions">Editions</a></li>[% END %][% END %] >-[% IF ( LocalCoverImages ) %][% IF ( localimages || CAN_user_tools_upload_local_cover_images ) %]<li><a href="#images">Images</a></li>[% END %][% END %] >+[% IF ( LocalCoverImages ) %] >+ [% IF ( localimages || CAN_user_tools_upload_local_cover_images ) %] >+ <li> >+ <a href="#images">Images ([% localimages.size() || 0 %])</a> >+ </li> >+ [% END %] >+[% END %] > [% IF ( HTML5MediaEnabled ) %][% IF ( HTML5MediaSets ) %]<li><a href="#html5media">Play media</a></li>[% END %][% END %] > [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && Koha.Preference('NovelistSelectStaffView') == 'tab' ) %] > <li class="NovelistSelect" style="display:none;"><a href="#NovelistSelect">NoveList Select</a></li> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10348
:
76417
|
76527
|
76535