Bug 10348 - Show number of items on tab headings in the staff client
Summary: Show number of items on tab headings in the staff client
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-27 12:44 UTC by Katrin Fischer
Modified: 2019-10-14 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10348: Show number of items on tab headings in the staff client (3.10 KB, patch)
2018-06-25 20:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10348: Show number of items on tab headings in the staff client (3.15 KB, patch)
2018-06-27 15:52 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 10348: Show number of items on tab headings in the staff client (3.23 KB, patch)
2018-06-27 19:00 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-05-27 12:44:38 UTC

    
Comment 1 Katrin Fischer 2013-05-27 12:45:56 UTC
When using the *SeparateHoldings system preferences the number of items for each tab is shown in the OPAC, but not in the staff interface.
Comment 2 Owen Leonard 2013-05-31 16:28:06 UTC
This isn't related to the SeparateHoldings preference. The staff client never shows a count of items in the holdings tab.
Comment 3 Marc Véron 2015-12-20 17:10:49 UTC
Still valid?
Comment 4 Owen Leonard 2018-06-25 20:11:13 UTC
Created attachment 76417 [details] [review]
Bug 10348: Show number of items on tab headings in the staff client

This patch uses Template Toolkit's size() method to add a count to
the bibliographic detail page's holdings and images tabs.

To test, apply the patch and view the detail page for a record in
the staff client. Check under the following conditions:

- The SeparateHoldings system preference is set to "Don't separate"
  - The holdings tab should show the correct item count.
- The SeparateHoldings system preference is set to "Separate"
  - The "[Library] holdings" tab and "Other holdings" tabs should
    have the correct item counts.
- With LocalCoverImages enabled the "Images" tab should show the
  correct count of attached images. Test with zero or more attached
  images.
Comment 5 Josef Moravec 2018-06-27 15:52:26 UTC
Created attachment 76527 [details] [review]
Bug 10348: Show number of items on tab headings in the staff client

This patch uses Template Toolkit's size() method to add a count to
the bibliographic detail page's holdings and images tabs.

To test, apply the patch and view the detail page for a record in
the staff client. Check under the following conditions:

- The SeparateHoldings system preference is set to "Don't separate"
  - The holdings tab should show the correct item count.
- The SeparateHoldings system preference is set to "Separate"
  - The "[Library] holdings" tab and "Other holdings" tabs should
    have the correct item counts.
- With LocalCoverImages enabled the "Images" tab should show the
  correct count of attached images. Test with zero or more attached
  images.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Jonathan Druart 2018-06-27 19:00:21 UTC
Created attachment 76535 [details] [review]
Bug 10348: Show number of items on tab headings in the staff client

This patch uses Template Toolkit's size() method to add a count to
the bibliographic detail page's holdings and images tabs.

To test, apply the patch and view the detail page for a record in
the staff client. Check under the following conditions:

- The SeparateHoldings system preference is set to "Don't separate"
  - The holdings tab should show the correct item count.
- The SeparateHoldings system preference is set to "Separate"
  - The "[Library] holdings" tab and "Other holdings" tabs should
    have the correct item counts.
- With LocalCoverImages enabled the "Images" tab should show the
  correct count of attached images. Test with zero or more attached
  images.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Nick Clemens 2018-06-29 21:03:50 UTC
Awesome work all!

Pushed to master for 18.11
Comment 8 Martin Renvoize 2018-07-02 09:08:15 UTC
Enhancement, not backporting to 18.05.x branch.