When using the *SeparateHoldings system preferences the number of items for each tab is shown in the OPAC, but not in the staff interface.
This isn't related to the SeparateHoldings preference. The staff client never shows a count of items in the holdings tab.
Still valid?
Created attachment 76417 [details] [review] Bug 10348: Show number of items on tab headings in the staff client This patch uses Template Toolkit's size() method to add a count to the bibliographic detail page's holdings and images tabs. To test, apply the patch and view the detail page for a record in the staff client. Check under the following conditions: - The SeparateHoldings system preference is set to "Don't separate" - The holdings tab should show the correct item count. - The SeparateHoldings system preference is set to "Separate" - The "[Library] holdings" tab and "Other holdings" tabs should have the correct item counts. - With LocalCoverImages enabled the "Images" tab should show the correct count of attached images. Test with zero or more attached images.
Created attachment 76527 [details] [review] Bug 10348: Show number of items on tab headings in the staff client This patch uses Template Toolkit's size() method to add a count to the bibliographic detail page's holdings and images tabs. To test, apply the patch and view the detail page for a record in the staff client. Check under the following conditions: - The SeparateHoldings system preference is set to "Don't separate" - The holdings tab should show the correct item count. - The SeparateHoldings system preference is set to "Separate" - The "[Library] holdings" tab and "Other holdings" tabs should have the correct item counts. - With LocalCoverImages enabled the "Images" tab should show the correct count of attached images. Test with zero or more attached images. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 76535 [details] [review] Bug 10348: Show number of items on tab headings in the staff client This patch uses Template Toolkit's size() method to add a count to the bibliographic detail page's holdings and images tabs. To test, apply the patch and view the detail page for a record in the staff client. Check under the following conditions: - The SeparateHoldings system preference is set to "Don't separate" - The holdings tab should show the correct item count. - The SeparateHoldings system preference is set to "Separate" - The "[Library] holdings" tab and "Other holdings" tabs should have the correct item counts. - With LocalCoverImages enabled the "Images" tab should show the correct count of attached images. Test with zero or more attached images. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Enhancement, not backporting to 18.05.x branch.