Bugzilla – Attachment 76554 Details for
Bug 19990
opac/opac-discharge.pl has a FIXME that can be fixed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19990: Removing unnecessary variable from opac/opac-discharge.pl
Bug-19990-Removing-unnecessary-variable-from-opaco.patch (text/plain), 1.45 KB, created by
Aleisha Amohia
on 2018-06-28 23:48:04 UTC
(
hide
)
Description:
Bug 19990: Removing unnecessary variable from opac/opac-discharge.pl
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2018-06-28 23:48:04 UTC
Size:
1.45 KB
patch
obsolete
>From 89696937559b630d091ab2011e20eac80d9e524b Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Thu, 28 Jun 2018 23:00:02 +0000 >Subject: [PATCH] Bug 19990: Removing unnecessary variable from > opac/opac-discharge.pl > >To test: >1) Ensure useDischarge syspref is enabled >2) Go to OPAC, click ask for a discharge >3) Go to staff side homepage, click 'Discharge requests pending' >4) Allow Discharge >5) Go to the user's page and remove the discharge restriction >6) Apply patch and repeat steps 2-4, ensuring that all behaviour stays >the same > >Sponsored-by: Catalyst IT >--- > opac/opac-discharge.pl | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > >diff --git a/opac/opac-discharge.pl b/opac/opac-discharge.pl >index 7653dc6..b82e46a 100755 >--- a/opac/opac-discharge.pl >+++ b/opac/opac-discharge.pl >@@ -96,14 +96,8 @@ else { > borrowernumber => $loggedinuser, > pending => 1, > }); >- # FIXME looks like $available is not needed >- # If a user is discharged they have a validated discharge available >- my $available = Koha::Patron::Discharge::count({ >- borrowernumber => $loggedinuser, >- validated => 1, >- }); > $template->param( >- available => $available && Koha::Patron::Discharge::is_discharged({borrowernumber => $loggedinuser}), >+ available => $pending && Koha::Patron::Discharge::is_discharged({borrowernumber => $loggedinuser}), > pending => $pending, > ); > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19990
:
70599
|
71864
| 76554