Bugzilla – Attachment 8131 Details for
Bug 7665
Bibs with no ISBN's show broken images for covers when using Syndetics cover images.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images
Bug-7665---Bibs-with-no-ISBNs-show-broken-images-f.patch (text/plain), 4.01 KB, created by
Ian Walls
on 2012-03-09 20:22:45 UTC
(
hide
)
Description:
Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images
Filename:
MIME Type:
Creator:
Ian Walls
Created:
2012-03-09 20:22:45 UTC
Size:
4.01 KB
patch
obsolete
>From 1196e25b95c02787f3a634ab1d3b48b8dea854c5 Mon Sep 17 00:00:00 2001 >From: Liz Rea <wizzyrea@gmail.com> >Date: Wed, 7 Mar 2012 13:29:58 -0600 >Subject: [PATCH] Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images > >Patch fixes problem for syndetics + bibs with no ISBN. Also adds "no image found" capability to Syndetics results. > >To test (first, contact me and I will let you use my syndetics credentials *for testing this bug only*): >* replicate bug - have a bib with an ISBN, and one without. The one with the ISBN should show a cover, the one without will show a broken image. >* apply patch >* search for the same bib - you should now see "no image available" for the one with no ISBN, and a cover image for your bib with an ISBN. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Ian Walls <koha.sekjal@gmail.com> >QA Comment: normalized spacing >--- > .../opac-tmpl/prog/en/modules/opac-results.tt | 17 +++++++++++++---- > 1 files changed, 13 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >index 26a97a4..bf0e6cd 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >@@ -535,10 +535,19 @@ $(document).ready(function(){ > [% IF ( OPACLocalCoverImages ) %]<span title="[% SEARCH_RESULT.biblionumber |url %]" class="[% SEARCH_RESULT.biblionumber %]" id="local-thumbnail[% loop.count %]"></span>[% END %] > [% IF ( OPACAmazonEnabled ) %][% IF ( OPACAmazonCoverImages ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<img src="http://images.amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" />[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %][% END %] > >- [% IF ( SyndeticsEnabled ) %][% IF ( SyndeticsCoverImages ) %][% IF ( using_https ) %] >- <img src="https://secure.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&client=[% SyndeticsClientCode %]&type=xw10&upc=[% SEARCH_RESULT.normalized_upc %]&oclc=[% SEARCH_RESULT.normalized_oclc %]" alt="" class="thumbnail" /> >- [% ELSE %] >- <img src="http://www.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&client=[% SyndeticsClientCode %]&type=xw10&upc=[% SEARCH_RESULT.normalized_upc %]&oclc=[% SEARCH_RESULT.normalized_oclc %]" alt="" class="thumbnail" />[% END %][% END %][% END %] >+ [% IF ( SyndeticsEnabled ) %] >+ [% IF ( SyndeticsCoverImages ) %] >+ [% IF SEARCH_RESULT.normalized_isbn %] >+ [% IF ( using_https ) %] >+ <img src="https://secure.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&client=[% SyndeticsClientCode %]&type=xw10&upc=[% SEARCH_RESULT.normalized_upc %]&oclc=[% SEARCH_RESULT.normalized_oclc %]" alt="" class="thumbnail" /> >+ [% ELSE %] >+ <img src="http://www.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&client=[% SyndeticsClientCode %]&type=xw10&upc=[% SEARCH_RESULT.normalized_upc %]&oclc=[% SEARCH_RESULT.normalized_oclc %]" alt="" class="thumbnail" /> >+ [% END %] >+ [% ELSE %] >+ <span class="no-image">No cover image available</span> >+ [% END %] >+ [% END %] >+ [% END %] > > [% IF ( GoogleJackets ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<div style="block" title="[% SEARCH_RESULT.biblionumber |url %]" class="[% SEARCH_RESULT.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></div>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %] > [% IF OpenLibraryCovers %][% IF SEARCH_RESULT.normalized_isbn %]<div style="block" title="[% SEARCH_RESULT.biblionumber %]" class="[% SEARCH_RESULT.normalized_isbn %]" id="openlibrary-thumbnail[% loop.count %]"></div>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %] >-- >1.7.0.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7665
:
8061
|
8062
| 8131