Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images.
Summary: Bibs with no ISBN's show broken images for covers when using Syndetics cover ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-07 17:21 UTC by Liz Rea
Modified: 2013-12-05 19:59 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images (4.03 KB, patch)
2012-03-07 20:08 UTC, Liz Rea
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images (3.98 KB, patch)
2012-03-07 20:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images (4.01 KB, patch)
2012-03-09 20:22 UTC, Ian Walls
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2012-03-07 17:21:40 UTC
When using the Syndetics service for enhanced content, bibs that have no ISBN numbers show broken images instead of "no image available" placeholders.
Comment 1 Liz Rea 2012-03-07 20:08:28 UTC Comment hidden (obsolete)
Comment 2 Liz Rea 2012-03-07 20:11:20 UTC
Wow, terrible test plan. 

First, make sure you have all other cover image sources off, and enable all syndetics options.

Then, proceed with testing per the plan.
Comment 3 Owen Leonard 2012-03-07 20:18:34 UTC Comment hidden (obsolete)
Comment 4 Ian Walls 2012-03-09 20:22:45 UTC
Created attachment 8131 [details] [review]
Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images

Patch fixes problem for syndetics + bibs with no ISBN. Also adds "no image found" capability to Syndetics results.

To test (first, contact me and I will let you use my syndetics credentials *for testing this bug only*):
* replicate bug - have a bib with an ISBN, and one without. The one with the ISBN should show a cover, the one without will show a broken image.
* apply patch
* search for the same bib - you should now see "no image available" for the one with no ISBN, and a cover image for your bib with an ISBN.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA Comment:  normalized spacing
Comment 5 Paul Poulain 2012-03-13 14:11:58 UTC
Patch pushed, (untested as I don't have syndetics credentials)
Comment 6 Jared Camins-Esakov 2012-05-09 20:02:40 UTC
This bug will be included in the Koha 3.6.5 release.