When using the Syndetics service for enhanced content, bibs that have no ISBN numbers show broken images instead of "no image available" placeholders.
Created attachment 8061 [details] [review] Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images Patch fixes problem for syndetics + bibs with no ISBN. Also adds "no image found" capability to Syndetics results. To test (first, contact me and I will let you use my syndetics credentials *for testing this bug only*): * replicate bug - have a bib with an ISBN, and one without. The one with the ISBN should show a cover, the one without will show a broken image. * apply patch * search for the same bib - you should now see "no image available" for the one with no ISBN, and a cover image for your bib with an ISBN.
Wow, terrible test plan. First, make sure you have all other cover image sources off, and enable all syndetics options. Then, proceed with testing per the plan.
Created attachment 8062 [details] [review] [SIGNED-OFF] Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images Patch fixes problem for syndetics + bibs with no ISBN. Also adds "no image found" capability to Syndetics results. To test (first, contact me and I will let you use my syndetics credentials *for testing this bug only*): * replicate bug - have a bib with an ISBN, and one without. The one with the ISBN should show a cover, the one without will show a broken image. * apply patch * search for the same bib - you should now see "no image available" for the one with no ISBN, and a cover image for your bib with an ISBN. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 8131 [details] [review] Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images Patch fixes problem for syndetics + bibs with no ISBN. Also adds "no image found" capability to Syndetics results. To test (first, contact me and I will let you use my syndetics credentials *for testing this bug only*): * replicate bug - have a bib with an ISBN, and one without. The one with the ISBN should show a cover, the one without will show a broken image. * apply patch * search for the same bib - you should now see "no image available" for the one with no ISBN, and a cover image for your bib with an ISBN. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Ian Walls <koha.sekjal@gmail.com> QA Comment: normalized spacing
Patch pushed, (untested as I don't have syndetics credentials)
This bug will be included in the Koha 3.6.5 release.