Bugzilla – Attachment 91838 Details for
Bug 23385
Hide default value fields by default on patron import
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23385: Hide 'Default values' fields by default
Bug-23385-Hide-Default-values-fields-by-default.patch (text/plain), 1.96 KB, created by
Maryse Simard
on 2019-07-26 18:43:02 UTC
(
hide
)
Description:
Bug 23385: Hide 'Default values' fields by default
Filename:
MIME Type:
Creator:
Maryse Simard
Created:
2019-07-26 18:43:02 UTC
Size:
1.96 KB
patch
obsolete
>From 748efbb4371964bbcf638c776588b8e7943add45 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 26 Jul 2019 14:48:51 +0000 >Subject: [PATCH] Bug 23385: Hide 'Default values' fields by default > >To test: >1 - Go to Tools->Import patrons >2 - Choose a file >3 - Scroll a long way to submit >4 - Apply patch >5 - Choose a file >6 - Can submit easily >7 - Click to expand and enter default fields >8 - Confirm can still submit and that values entered are used > >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> >--- > .../intranet-tmpl/prog/en/modules/tools/import_borrowers.tt | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt >index 2133770..02420a9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt >@@ -159,9 +159,12 @@ > </fieldset> > > <fieldset class="rows"> >- <legend>Default values</legend> >+ <legend> >+ <a class="expand_defaults">Click to enter default values</a> >+ <a class="expand_defaults" style="display:none;">Hide default value fields</a> >+ </legend> > >- <ol> >+ <ol class="default_values" style="display:none;"> > [% FOREACH borrower_field IN borrower_fields %] > > [% SWITCH borrower_field.field %] >@@ -303,6 +306,11 @@ you can supply dates in ISO format (e.g., '2010-10-28'). > $(document).ready(function() { > [%# Make date fields have the datepicker %] > $("#dateenrolled, #dateexpiry, #dateofbirth").datepicker(); >+ >+ $(".expand_defaults").click(function(){ >+ $(".default_values").toggle(); >+ $(".expand_defaults").toggle(); >+ }); > }); > </script> > [% END %] >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23385
:
91813
|
91838
|
91850
|
91859
|
91860
|
92094