When importing patrons there is a very long form to supply default values for patron fields. This is not always used and can be hidden unless needed to make the form display nicer
Created attachment 91813 [details] [review] Bug 23385: Hide 'Default values' fields by default To test: 1 - Go to Tools->Import patrons 2 - Choose a file 3 - Scroll a long way to submit 4 - Apply patch 5 - Choose a file 6 - Can submit easily 7 - Click to expand and enter default fields 8 - Confirm can still submit and that values entered are used
Created attachment 91838 [details] [review] Bug 23385: Hide 'Default values' fields by default To test: 1 - Go to Tools->Import patrons 2 - Choose a file 3 - Scroll a long way to submit 4 - Apply patch 5 - Choose a file 6 - Can submit easily 7 - Click to expand and enter default fields 8 - Confirm can still submit and that values entered are used Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 91850 [details] [review] Bug 23385: (follow-up) Update link This follow-up adds a dummy href attribute to the link for showing and hiding the default values form so that it behaves more like a link. I removed "click to" from the link text and added Font Awesome icons common to "show/hide" links.
Created attachment 91859 [details] [review] Bug 23385: Hide 'Default values' fields by default To test: 1 - Go to Tools->Import patrons 2 - Choose a file 3 - Scroll a long way to submit 4 - Apply patch 5 - Choose a file 6 - Can submit easily 7 - Click to expand and enter default fields 8 - Confirm can still submit and that values entered are used Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: George Williams <george@nekls.org>
Created attachment 91860 [details] [review] Bug 23385: (follow-up) Update link This follow-up adds a dummy href attribute to the link for showing and hiding the default values form so that it behaves more like a link. I removed "click to" from the link text and added Font Awesome icons common to "show/hide" links. Signed-off-by: George Williams <george@nekls.org>
Created attachment 92094 [details] [review] Bug 23385: (follow-up) Update link This follow-up adds a dummy href attribute to the link for showing and hiding the default values form so that it behaves more like a link. I removed "click to" from the link text and added Font Awesome icons common to "show/hide" links. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Small enhancement, I choose to backport. Pushed to 19.05.x for 19.05.04
enhancement, wont backport to 18.11.x