Summary: | Improve importation of .CSV framework files | ||
---|---|---|---|
Product: | Koha | Reporter: | Mason James <mtj> |
Component: | System Administration | Assignee: | Mason James <mtj> |
Status: | Failed QA --- | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, gitbot, gmcharlt, jonathan.druart, katrin.fischer, kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 10538 - Improve importation of .CSV framework files
Bug 10538 - Improve importation of .CSV framework files Bug 8368: (follow-up) restore use of quoted printable for message body Signed-off-by: Joy Nelson <joy@bywatersolutions.com> |
Description
Mason James
2013-07-03 23:21:30 UTC
Created attachment 19400 [details] [review] Bug 10538 - Improve importation of .CSV framework files this patch is basically a rewrite of the _import_table_csv() sub, using Text::CSV to test this patch... 1/ dump a framework as a .csv file, to your disk 2/ open that .csv file in LibreOffice (or OpenOffice) and save that file as a new.csv note: LO/OO has just created a 'broken' new.csv file 3/ import new.csv file into Koha, (the import should FAIL) 4/ apply patch and repeat step 3, (the import should SUCCEED) My saved LibreOffice csv failed to import both pre and post patch. Mason, Could you describe the issue? I cannot reproduce, the csv file seems good for the default framework and the acquisition framework. I don't get any error log output, just an import failed message from the browser. Perhaps if you uploaded a pair of framework files for testing, it would help. I confirm I cannot reproduce. Tested with several frameworks. Maybe it would be useful to attach a csv framework file to this report? Patch applied cleanly, go forth and signoff Created attachment 22112 [details] [review] Bug 10538 - Improve importation of .CSV framework files this patch is basically a rewrite of the _import_table_csv() sub, using Text::CSV to test this patch... 1/ dump a framework as a .csv file, to your disk 2/ open that .csv file in LibreOffice (or OpenOffice) and save that file as a new.csv note: LO/OO has just created a 'broken' new.csv file 3/ import new.csv file into Koha, (the import should FAIL) 4/ apply patch and repeat step 3, (the import should SUCCEED) Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Created attachment 22113 [details] [review] Bug 8368: (follow-up) restore use of quoted printable for message body This is necessary to prevent the equals sign that is part of the link back to the OPAC from being mangled, thereby breaking the link. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Created attachment 22114 [details] [review] Signed-off-by: Joy Nelson <joy@bywatersolutions.com> I am a bit worried about this rewrite. OO/LibreOffice seems to remove the quotation marks from the fields when you save the file with a new name. The patch makes it possible to import the file anyway. But this can lead to other problems, for example it would be possible to have a comma in one of the descriptions and this field would not be imported, without any warning or error message. I also wonder about the use case here, because we also offer a specific spreadsheet format to be used with OO/Libre Office. I am moving this to failed QA - see questions and notes in comment 10. Still valid? |