Bug 10538

Summary: Improve importation of .CSV framework files
Product: Koha Reporter: Mason James <mtj>
Component: System AdministrationAssignee: Mason James <mtj>
Status: Failed QA --- QA Contact:
Severity: normal    
Priority: P5 - low CC: 1joynelson, gitbot, gmcharlt, jonathan.druart, katrin.fischer, kyle, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 10538 - Improve importation of .CSV framework files
Bug 10538 - Improve importation of .CSV framework files
Bug 8368: (follow-up) restore use of quoted printable for message body
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>

Description Mason James 2013-07-03 23:21:30 UTC
Koha often fails when importing CSV framework files, because Koha can currently only import 'perfectly quoted' CSV files

this patch uses the amazing Text::CSV module to improve the robustness of the importation process
Comment 1 Mason James 2013-07-05 04:32:12 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-07-05 15:19:59 UTC
My saved LibreOffice csv failed to import both pre and post patch.
Comment 3 Jonathan Druart 2013-07-09 10:46:49 UTC
Mason,
Could you describe the issue? I cannot reproduce, the csv file seems good for the default framework and the acquisition framework.
Comment 4 Kyle M Hall 2013-07-09 10:56:37 UTC
I don't get any error log output, just an import failed message from the browser. Perhaps if you uploaded a pair of framework files for testing, it would help.
Comment 5 Jonathan Druart 2013-07-09 14:41:35 UTC
I confirm I cannot reproduce. Tested with several frameworks. Maybe it would be useful to attach a csv framework file to this report?
Comment 6 I'm just a bot 2013-09-29 05:31:04 UTC
Patch applied cleanly, go forth and signoff
Comment 7 Joy Nelson 2013-10-20 21:14:23 UTC Comment hidden (obsolete)
Comment 8 Joy Nelson 2013-10-20 21:16:07 UTC Comment hidden (obsolete)
Comment 9 Joy Nelson 2013-10-20 21:17:07 UTC
Created attachment 22114 [details] [review]
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Comment 10 Katrin Fischer 2013-10-27 17:30:43 UTC
I am a bit worried about this rewrite.

OO/LibreOffice seems to remove the quotation marks from the fields when you save the file with a new name.

The patch makes it possible to import the file anyway. But this can lead to other problems, for example it would be possible to have a comma in one of the descriptions and this field would not be imported, without any warning or error message.

I also wonder about the use case here, because we also offer a specific spreadsheet format to be used with OO/Libre Office.
Comment 11 Katrin Fischer 2013-12-03 11:38:42 UTC
I am moving this to failed QA - see questions and notes in comment 10.
Comment 12 Marc VĂ©ron 2016-10-04 16:14:36 UTC
Still valid?