This is the same problem as for bug 8062 only for sending out lists. Copying description with some changes: To reproduce: - Create a list that you can access - Open list in OPAC or staff - log in, if you didn't before - Send list to any email address - Check email text and attachements The mail sent from the translated templates has subject "no subject" and is empty. The marc files are attached. The mail sent from the english templates is all correct.
Created attachment 21427 [details] [review] Proposed patch This patch ports to list sending by email, the technic used in sending cart, ie (1) format email in HTML, and (2) transform it into Text with TT filter html2text.
This works for me except where the template tries to show subtitles. I get something like this: Swiss Family Robinson ARRAY(0xc0a58b4) Your patch removes this: - [% IF ( BIBLIO_RESULT.subtitle.size ) %] [% FOREACH subtitle IN BIBLIO_RESULT.subtitle %][% subtitle.subfield %][% END %][% END %] ...in favor of this: + [% IF ( BIBLIO_RESULT.subtitle ) %] [% BIBLIO_RESULT.subtitle %][% END %] BIBLIO_RESULT.subtitle is not a simple variable, hence the way it was handled previously.
Created attachment 21447 [details] [review] [SIGNED-OFF] Bug 8368 List email broken for non english templates This patch ports to list sending by email, the technic used in sending cart, ie (1) format email in HTML, and (2) transform it into Text with TT filter html2text. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No koha-qa errors Test 1) Installed language other than english 2) Create new list, add a few books 3) Send list in english, subject Ok 4) Swith opac lang, send list, No subject 5) Apply patch 6) Send list in english, subject Ok 7) Switch opac lang, send list, subject Ok
Created attachment 21448 [details] [review] Proposed patch (v2 see Owen comment) Restore proper subtitle display? Thanks Owen. Something in my devel DB, or in UNIMARC, prevent subtitle display. I hope it works for MARC21/your DB.
Created attachment 21457 [details] [review] [SIGNED-OFF] Bug 8368 List email broken for non english templates This patch ports to list sending by email, the technic used in sending cart, ie (1) format email in HTML, and (2) transform it into Text with TT filter html2text. Note: V2 of this patch: Restore proper subtile display. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 21529 [details] [review] [PASSED QA] Bug 8368 List email broken for non english templates This patch ports to list sending by email, the technic used in sending cart, ie (1) format email in HTML, and (2) transform it into Text with TT filter html2text. Note: V2 of this patch: Restore proper subtile display. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes a very annoying translation bug successfully. Also passes all tests and QA script. To test: - Add a few records to a shelf, ideally use some with diacritics. - Send shelf from English templates, verify email is ok - Send shelf from translated templates (de-DE or similar) - verify email content is broken. - Apply patches, update po files and reinstall the language. - Send shelf from English templates again, verify there is no regression. - Send shelf form translates templates - verify this email is now also working correctly. Patch also changes the name of the file attachement from shelf.iso2709 to list.iso2709.
Pushed to master, along with follow-ups to restore the display of ISBNs in the email, porting the template change to the new Bootstrap theme, and restoring the use of encode_qp(). Thanks, Frédéric! As a side note, perhaps the email templates should probably be moved outside of the OPAC theme template directories.
Hi Tomas, I think we shoudl have this in 3.12 as list emails are still broken there. Could you consider for your next release?
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Frederic!