Bug 10557

Summary: GetBooksellersWithLateOrders has an unused branch parameter
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: AcquisitionsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: bgkriegel, gmcharlt, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 10528    
Attachments: Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter
[SIGNED-OFF] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter
[PASSED QA] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter

Description Jonathan Druart 2013-07-09 10:01:32 UTC

    
Comment 1 Jonathan Druart 2013-07-09 10:03:38 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2013-07-16 23:19:36 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-07-22 17:36:12 UTC
Created attachment 19856 [details] [review]
[PASSED QA] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter

C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter.
The $branch variable is never used in the routine.

Test plan:
Check that no behavior changes on the late orders page.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I couldn't find any use of the branch parameter apart from
the one corrected by this patch. Also tested late orders,
couldn't find any problems.
Comment 4 Galen Charlton 2013-07-22 19:02:37 UTC
Pushed to master.  Thanks, Jonathan!
Comment 5 Tomás Cohen Arazi 2013-09-13 17:29:35 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Jonathan!
Comment 6 Bernardo Gonzalez Kriegel 2013-10-13 13:22:15 UTC
Pushed to 3.10.x, will be in 3.10.12