Bug 10557 - GetBooksellersWithLateOrders has an unused branch parameter
Summary: GetBooksellersWithLateOrders has an unused branch parameter
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 10528
  Show dependency treegraph
 
Reported: 2013-07-09 10:01 UTC by Jonathan Druart
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter (1.70 KB, patch)
2013-07-09 10:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter (1.76 KB, patch)
2013-07-16 23:19 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
[PASSED QA] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter (1.96 KB, patch)
2013-07-22 17:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-07-09 10:01:32 UTC

    
Comment 1 Jonathan Druart 2013-07-09 10:03:38 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2013-07-16 23:19:36 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-07-22 17:36:12 UTC
Created attachment 19856 [details] [review]
[PASSED QA] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter

C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter.
The $branch variable is never used in the routine.

Test plan:
Check that no behavior changes on the late orders page.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I couldn't find any use of the branch parameter apart from
the one corrected by this patch. Also tested late orders,
couldn't find any problems.
Comment 4 Galen Charlton 2013-07-22 19:02:37 UTC
Pushed to master.  Thanks, Jonathan!
Comment 5 Tomás Cohen Arazi 2013-09-13 17:29:35 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Jonathan!
Comment 6 Bernardo Gonzalez Kriegel 2013-10-13 13:22:15 UTC
Pushed to 3.10.x, will be in 3.10.12