Created attachment 19499 [details] [review] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. The $branch variable is never used in the routine. Test plan: Check that no behavior changes on the late orders page.
Created attachment 19699 [details] [review] [SIGNED-OFF] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. The $branch variable is never used in the routine. Test plan: Check that no behavior changes on the late orders page. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Created attachment 19856 [details] [review] [PASSED QA] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. The $branch variable is never used in the routine. Test plan: Check that no behavior changes on the late orders page. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I couldn't find any use of the branch parameter apart from the one corrected by this patch. Also tested late orders, couldn't find any problems.
Pushed to master. Thanks, Jonathan!
This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Jonathan!
Pushed to 3.10.x, will be in 3.10.12