Bug 10730

Summary: Use DataTables on the tag review page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: ToolsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, jonathan.druart, julian.maurice
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/tags/review.pl
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 10649    
Bug Blocks:    
Attachments: Bug 10730 - Use DataTables on the tag review page
[SIGNED-OFF] Bug 10730 - Use DataTables on the tag review page
Bug 10730 - Use DataTables on the tag review page
Bug 10730: Restore background color for cells

Description Owen Leonard 2013-08-14 16:09:32 UTC
The tag review page in the staff client could benefit from having a sortable table.
Comment 1 Owen Leonard 2013-09-09 16:35:27 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2013-09-24 11:42:15 UTC Comment hidden (obsolete)
Comment 3 Julian Maurice 2013-09-24 11:46:10 UTC
All is working well, so I signoff.
But we lose background colors in status cells. I don't know if this should prevent this patch to be pushed.
Comment 4 Jonathan Druart 2013-09-24 12:58:12 UTC
Created attachment 21413 [details] [review]
Bug 10730 - Use DataTables on the tag review page

This patch enhances the tags review page in the staff client by adding
DataTables sorting to the table of tags.

It also converts the tag list page (list.tt) to use the new DataTables
include introduced by Bug 10649.

To test, apply the patch and view the tags review page for various
categories: Pending, approved, rejected, all. The table should be
sortable by status, term, weight, and date. Sorting by date should work
correctly regardless of date format preference. Title sorting on the tag
list page should work correctly.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: Replace tab with 4 spaces

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2013-09-24 12:58:25 UTC
Created attachment 21414 [details] [review]
Bug 10730: Restore background color for cells

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Jonathan Druart 2013-09-24 12:59:24 UTC
(In reply to Julian Maurice from comment #3)
> All is working well, so I signoff.
> But we lose background colors in status cells. I don't know if this should
> prevent this patch to be pushed.

Fixed in the followup.
Works as before, no regression found.
Marked as Passed QA.
Comment 7 Galen Charlton 2013-09-25 16:50:27 UTC
Pushed to master.  Thanks, Owen!