The tag review page in the staff client could benefit from having a sortable table.
Created attachment 20921 [details] [review] Bug 10730 - Use DataTables on the tag review page This patch enhances the tags review page in the staff client by adding DataTables sorting to the table of tags. It also converts the tag list page (list.tt) to use the new DataTables include introduced by Bug 10649. To test, apply the patch and view the tags review page for various categories: Pending, approved, rejected, all. The table should be sortable by status, term, weight, and date. Sorting by date should work correctly regardless of date format preference. Title sorting on the tag list page should work correctly.
Created attachment 21411 [details] [review] [SIGNED-OFF] Bug 10730 - Use DataTables on the tag review page This patch enhances the tags review page in the staff client by adding DataTables sorting to the table of tags. It also converts the tag list page (list.tt) to use the new DataTables include introduced by Bug 10649. To test, apply the patch and view the tags review page for various categories: Pending, approved, rejected, all. The table should be sortable by status, term, weight, and date. Sorting by date should work correctly regardless of date format preference. Title sorting on the tag list page should work correctly. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
All is working well, so I signoff. But we lose background colors in status cells. I don't know if this should prevent this patch to be pushed.
Created attachment 21413 [details] [review] Bug 10730 - Use DataTables on the tag review page This patch enhances the tags review page in the staff client by adding DataTables sorting to the table of tags. It also converts the tag list page (list.tt) to use the new DataTables include introduced by Bug 10649. To test, apply the patch and view the tags review page for various categories: Pending, approved, rejected, all. The table should be sortable by status, term, weight, and date. Sorting by date should work correctly regardless of date format preference. Title sorting on the tag list page should work correctly. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Replace tab with 4 spaces Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 21414 [details] [review] Bug 10730: Restore background color for cells Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(In reply to Julian Maurice from comment #3) > All is working well, so I signoff. > But we lose background colors in status cells. I don't know if this should > prevent this patch to be pushed. Fixed in the followup. Works as before, no regression found. Marked as Passed QA.
Pushed to master. Thanks, Owen!