Summary: | Fix synopsis for -html option to overdue_notices.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Command-line Utilities | Assignee: | Magnus Enger <magnus> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 10810 - Fix synopsis for -html option to overdue_notices.pl
[SIGNED-OFF] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl [PASSED QA] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl |
Description
Magnus Enger
2013-08-31 13:24:11 UTC
Created attachment 20749 [details] [review] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl The synopsis for the -html option used to be: -html <filename> Output html to file but the argument to this option should actually be a directory, not a filename. This patch fixes the synopsis. To test: - Run perldoc misc/cronjobs/overdue_notices.pl - Check that the synopsis is as shown above - Apply this patch - Run perldoc misc/cronjobs/overdue_notices.pl - Check that - the synopsis asks for a directory, not a filename - that the description of the -html option further down in the perldoc now mentions the filename that the HTML file will be created with. Created attachment 20870 [details] [review] [SIGNED-OFF] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl The synopsis for the -html option used to be: -html <filename> Output html to file but the argument to this option should actually be a directory, not a filename. This patch fixes the synopsis. To test: - Run perldoc misc/cronjobs/overdue_notices.pl - Check that the synopsis is as shown above - Apply this patch - Run perldoc misc/cronjobs/overdue_notices.pl - Check that - the synopsis asks for a directory, not a filename - that the description of the -html option further down in the perldoc now mentions the filename that the HTML file will be created with. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described. No koha-qa errors. If feeded with a filename -html option fails with many messages like print() on closed filehandle $html_fh at misc/cronjobs/overdue_notices.pl line 384. Perhaps it could be improved, but that was the old behavior. Created attachment 20976 [details] [review] [PASSED QA] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl The synopsis for the -html option used to be: -html <filename> Output html to file but the argument to this option should actually be a directory, not a filename. This patch fixes the synopsis. To test: - Run perldoc misc/cronjobs/overdue_notices.pl - Check that the synopsis is as shown above - Apply this patch - Run perldoc misc/cronjobs/overdue_notices.pl - Check that - the synopsis asks for a directory, not a filename - that the description of the -html option further down in the perldoc now mentions the filename that the HTML file will be created with. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described. No koha-qa errors. If feeded with a filename -html option fails with many messages like print() on closed filehandle $html_fh at misc/cronjobs/overdue_notices.pl line 384. Perhaps it could be improved, but that was the old behavior. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Improves documentation, no negative side effects found. Pushed to master. Thanks, Magnus! This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Magnus! |