See http://perldoc.koha-community.org/misc/cronjobs/overdue_notices.html The synopsis says: -html <filename> Output html to file But the description of the -html option says: -html Produces html data. if patron does not have a mail address or -n (no mail) flag is set, an html file is generated in the specified directory. This can be downloaded or futher processed by library staff. If the -html option is given a filename as its argument it will fail without warning. Confusingly enough, the variable associated with the -html option is called $htmlfilename: 'html:s' => \$htmlfilename, But it is actually used as a path, and the filename is added to it: open $html_fh, ">",File::Spec->catdir ($htmlfilename,"notices-".$today->ymd().".html"); I'll do a patch that fixes the synopsis and makes the full description clearer, but leave the variable name alone, as changing it will not gain us much.
Created attachment 20749 [details] [review] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl The synopsis for the -html option used to be: -html <filename> Output html to file but the argument to this option should actually be a directory, not a filename. This patch fixes the synopsis. To test: - Run perldoc misc/cronjobs/overdue_notices.pl - Check that the synopsis is as shown above - Apply this patch - Run perldoc misc/cronjobs/overdue_notices.pl - Check that - the synopsis asks for a directory, not a filename - that the description of the -html option further down in the perldoc now mentions the filename that the HTML file will be created with.
Created attachment 20870 [details] [review] [SIGNED-OFF] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl The synopsis for the -html option used to be: -html <filename> Output html to file but the argument to this option should actually be a directory, not a filename. This patch fixes the synopsis. To test: - Run perldoc misc/cronjobs/overdue_notices.pl - Check that the synopsis is as shown above - Apply this patch - Run perldoc misc/cronjobs/overdue_notices.pl - Check that - the synopsis asks for a directory, not a filename - that the description of the -html option further down in the perldoc now mentions the filename that the HTML file will be created with. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described. No koha-qa errors. If feeded with a filename -html option fails with many messages like print() on closed filehandle $html_fh at misc/cronjobs/overdue_notices.pl line 384. Perhaps it could be improved, but that was the old behavior.
Created attachment 20976 [details] [review] [PASSED QA] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl The synopsis for the -html option used to be: -html <filename> Output html to file but the argument to this option should actually be a directory, not a filename. This patch fixes the synopsis. To test: - Run perldoc misc/cronjobs/overdue_notices.pl - Check that the synopsis is as shown above - Apply this patch - Run perldoc misc/cronjobs/overdue_notices.pl - Check that - the synopsis asks for a directory, not a filename - that the description of the -html option further down in the perldoc now mentions the filename that the HTML file will be created with. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described. No koha-qa errors. If feeded with a filename -html option fails with many messages like print() on closed filehandle $html_fh at misc/cronjobs/overdue_notices.pl line 384. Perhaps it could be improved, but that was the old behavior. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Improves documentation, no negative side effects found.
Pushed to master. Thanks, Magnus!
This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Magnus!