Description
Jonathan Druart
2013-09-10 11:41:31 UTC
Created attachment 20945 [details] [review] Bug 10852: serials search improvements This patch adds 3 filters for the serials search: - location - callnumber - expiration date To test: - Search serials by location and/or callnumber and/or expiration date and check that results are consistent. Patch applied cleanly, go forth and signoff Patch applied cleanly, go forth and signoff It works well, but - I thought the filter on expiration date was checking the exact date. It seems that it getting subscriptions ending BEFORE the given date. Am I right? So, could you rephrase the name of the filter, so that it be obvious for users? - Search on Callnumber is not very precise. I had a callnumber "XC BLA", and get the subscription with a search on callnumber "LA" or "X" I think callnumber filter should search for complete words, but I'm not sure it is the case elsewhere in Koha. I'm waiting for your reaction, and for the moment, I keep the bug in Needs Signoff status. Mathieu (In reply to mathieu saby from comment #4) > So, could you rephrase the name of the filter, so that it be obvious for users? I will submit a followup. > I had a callnumber "XC BLA", and get the subscription with a search on > callnumber "LA" or "X" > I think callnumber filter should search for complete words, but I'm not sure > it is the case elsewhere in Koha. I think it is an acceptable behavior, it is like it works in GetSubscriptions too. Created attachment 23294 [details] [review] Bug 10852: Rename the "expiration date" filter name
> > I had a callnumber "XC BLA", and get the subscription with a search on
> > callnumber "LA" or "X"
> > I think callnumber filter should search for complete words, but I'm not sure
> > it is the case elsewhere in Koha.
>
> I think it is an acceptable behavior, it is like it works in
> GetSubscriptions too.
OK. anyway it should not be a blocker for this enh. If someone wants to improve this behavior, he can do it later...
Mathieu
Created attachment 23295 [details] [review] [PATCH][SIGNED OFF] Bug 10852: serials search improvements Created attachment 23296 [details] [review] [PATCH][SIGNED OFF] Bug 10852: Rename the "expiration date" filter name I sign off Created attachment 23548 [details] [review] Bug 10852: QA Followup - Switch from KohaAuthorisedValues to AuthorisedValues Bug 10626 will remove the KohaAuthorisedValues plugin and keep the AuthorisedValues plugin. Created attachment 23549 [details] [review] Bug 10852: serials search improvements This patch adds 3 filters for the serials search: - location - callnumber - expiration date To test: - Search serials by location and/or callnumber and/or expiration date and check that results are consistent. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 23550 [details] [review] Bug 10852: Rename the "expiration date" filter name Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 23551 [details] [review] Bug 10852: QA Followup - Switch from KohaAuthorisedValues to AuthorisedValues Bug 10626 will remove the KohaAuthorisedValues plugin and keep the AuthorisedValues plugin. Pushed to master, along with some minor follow-ups. Thanks, Jonathan! Patches pushed to 3.14.x, will be in 3.14.2 |