Bug 10852 - Add 3 filters to the serials search
Summary: Add 3 filters to the serials search
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-10 11:41 UTC by Jonathan Druart
Modified: 2015-06-04 23:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10852: serials search improvements (12.43 KB, patch)
2013-09-10 12:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10852: Rename the "expiration date" filter name (1.50 KB, patch)
2013-12-04 13:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PATCH][SIGNED OFF] Bug 10852: serials search improvements (12.50 KB, patch)
2013-12-04 13:49 UTC, Mathieu Saby
Details | Diff | Splinter Review
[PATCH][SIGNED OFF] Bug 10852: Rename the "expiration date" filter name (1.57 KB, patch)
2013-12-04 13:50 UTC, Mathieu Saby
Details | Diff | Splinter Review
Bug 10852: QA Followup - Switch from KohaAuthorisedValues to AuthorisedValues (2.35 KB, patch)
2013-12-13 20:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10852: serials search improvements (12.60 KB, patch)
2013-12-13 20:40 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10852: Rename the "expiration date" filter name (1.60 KB, patch)
2013-12-13 20:40 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10852: QA Followup - Switch from KohaAuthorisedValues to AuthorisedValues (2.35 KB, patch)
2013-12-13 20:41 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-09-10 11:41:31 UTC
The serial module offers some filters to search serials.
But 3 are missing: location, callnumber and expiration date.
This feature will add them.
Comment 1 Jonathan Druart 2013-09-10 12:19:00 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-09-29 05:55:42 UTC
Patch applied cleanly, go forth and signoff
Comment 3 I'm just a bot 2013-10-24 19:39:39 UTC
Patch applied cleanly, go forth and signoff
Comment 4 Mathieu Saby 2013-11-29 20:02:40 UTC
It works well, but
- I thought the filter on expiration date was checking the exact date. It seems that it getting subscriptions ending BEFORE the given date. Am I right? So, could you rephrase the name of the filter, so that it be obvious for users?

- Search on Callnumber is not very precise.
I had a callnumber "XC BLA", and get the subscription with a search on callnumber "LA" or "X"
I think callnumber filter should search for complete words, but I'm not sure it is the case elsewhere in Koha.

I'm waiting for your reaction, and for the moment, I keep the bug in Needs Signoff status.

Mathieu
Comment 5 Jonathan Druart 2013-12-04 13:42:16 UTC
(In reply to mathieu saby from comment #4)
> So, could you rephrase the name of the filter, so that it be obvious for users?

I will submit a followup.

> I had a callnumber "XC BLA", and get the subscription with a search on
> callnumber "LA" or "X"
> I think callnumber filter should search for complete words, but I'm not sure
> it is the case elsewhere in Koha.

I think it is an acceptable behavior, it is like it works in GetSubscriptions too.
Comment 6 Jonathan Druart 2013-12-04 13:42:54 UTC Comment hidden (obsolete)
Comment 7 Mathieu Saby 2013-12-04 13:45:28 UTC
> > I had a callnumber "XC BLA", and get the subscription with a search on
> > callnumber "LA" or "X"
> > I think callnumber filter should search for complete words, but I'm not sure
> > it is the case elsewhere in Koha.
> 
> I think it is an acceptable behavior, it is like it works in
> GetSubscriptions too.

OK. anyway it should not be a blocker for this enh. If someone wants to improve this behavior, he can do it later...

Mathieu
Comment 8 Mathieu Saby 2013-12-04 13:49:53 UTC Comment hidden (obsolete)
Comment 9 Mathieu Saby 2013-12-04 13:50:15 UTC Comment hidden (obsolete)
Comment 10 Mathieu Saby 2013-12-04 13:50:27 UTC
I sign off
Comment 11 Kyle M Hall 2013-12-13 20:36:10 UTC Comment hidden (obsolete)
Comment 12 Kyle M Hall 2013-12-13 20:40:21 UTC
Created attachment 23549 [details] [review]
Bug 10852: serials search improvements

This patch adds 3 filters for the serials search:
- location
- callnumber
- expiration date

To test:
- Search serials by location and/or callnumber and/or expiration date
  and check that results are consistent.

Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 13 Kyle M Hall 2013-12-13 20:40:30 UTC
Created attachment 23550 [details] [review]
Bug 10852: Rename the "expiration date" filter name

Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 14 Kyle M Hall 2013-12-13 20:41:20 UTC
Created attachment 23551 [details] [review]
Bug 10852: QA Followup - Switch from KohaAuthorisedValues to AuthorisedValues

Bug 10626 will remove the KohaAuthorisedValues plugin and keep the
AuthorisedValues plugin.
Comment 15 Galen Charlton 2013-12-14 00:38:23 UTC
Pushed to master, along with some minor follow-ups.  Thanks, Jonathan!
Comment 16 Fridolin Somers 2013-12-30 09:35:21 UTC
Patches pushed to 3.14.x, will be in 3.14.2