Summary: | Filters are not kept on receiving | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, katrin.fischer, nengard, nicolas.bravais, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 11141: Filters are not kept on receiving.
Bug 11141: Filters are not kept on receiving. Bug 11141: Filters are not kept on receiving. Bug 11141: Filters should be kept if the receive is cancelled [PASSED QA] Bug 11141: Filters are not kept on receiving. [PASSED QA] Bug 11141: Filters should be kept if the receive is cancelled |
Description
Jonathan Druart
2013-10-25 14:41:09 UTC
Created attachment 22412 [details] [review] Bug 11141: Filters are not kept on receiving. On receiving orders, the librarian has to filter again the pending orders list. This patch stores the filters in a cookie in order to apply them when the librarian finish a receive and come back on the pending orders list. Test plan: 1/ choose a vendor with several baskets and orders. 2/ start to receive an item. 3/ on the pending orders page, add some relevant filters. 4/ receive an item. 5/ you are back on the pending orders page and filters are directly applied. Created attachment 24051 [details] [review] Bug 11141: Filters are not kept on receiving. On receiving orders, the librarian has to filter again the pending orders list. This patch stores the filters in a cookie in order to apply them when the librarian finish a receive and come back on the pending orders list. Test plan: 1/ choose a vendor with several baskets and orders. 2/ start to receive an item. 3/ on the pending orders page, add some relevant filters. 4/ receive an item. 5/ you are back on the pending orders page and filters are directly applied. Last patch is just a rebase. Patch tested with a sandbox, by Nicolas Bravais <nicolas.bravais@gmail.com> Created attachment 24108 [details] [review] Bug 11141: Filters are not kept on receiving. On receiving orders, the librarian has to filter again the pending orders list. This patch stores the filters in a cookie in order to apply them when the librarian finish a receive and come back on the pending orders list. Test plan: 1/ choose a vendor with several baskets and orders. 2/ start to receive an item. 3/ on the pending orders page, add some relevant filters. 4/ receive an item. 5/ you are back on the pending orders page and filters are directly applied. Signed-off-by: Nicolas Bravais <nicolas.bravais@gmail.com> Filters are still applied after receiving an item. (tested with title, then basket, then author+basket) Hi Jonathan, I think I found a small problem: if you don't save, but go back with cancel, because you picked the wrong order, the filters are still lost. Could this be fixd as well? Created attachment 24381 [details] [review] Bug 11141: Filters should be kept if the receive is cancelled (In reply to Katrin Fischer from comment #7) > Hi Jonathan, > I think I found a small problem: if you don't save, but go back with cancel, > because you picked the wrong order, the filters are still lost. Could this > be fixd as well? Hi Katrin, Yes it seems consistent. Last patch fixes that. Created attachment 24536 [details] [review] [PASSED QA] Bug 11141: Filters are not kept on receiving. On receiving orders, the librarian has to filter again the pending orders list. This patch stores the filters in a cookie in order to apply them when the librarian finish a receive and come back on the pending orders list. Test plan: 1/ choose a vendor with several baskets and orders. 2/ start to receive an item. 3/ on the pending orders page, add some relevant filters. 4/ receive an item. 5/ you are back on the pending orders page and filters are directly applied. Signed-off-by: Nicolas Bravais <nicolas.bravais@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested with receiving and cancelling the receive process the filters are kept. Created attachment 24537 [details] [review] [PASSED QA] Bug 11141: Filters should be kept if the receive is cancelled Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pushed to master. Thanks, Jonathan! *** Bug 6741 has been marked as a duplicate of this bug. *** |