Bug 11141 - Filters are not kept on receiving
Summary: Filters are not kept on receiving
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
: 6741 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-10-25 14:41 UTC by Jonathan Druart
Modified: 2015-03-27 09:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11141: Filters are not kept on receiving. (5.37 KB, patch)
2013-10-25 14:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11141: Filters are not kept on receiving. (5.30 KB, patch)
2014-01-09 11:36 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11141: Filters are not kept on receiving. (5.36 KB, patch)
2014-01-10 09:33 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 11141: Filters should be kept if the receive is cancelled (1.11 KB, patch)
2014-01-15 09:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 11141: Filters are not kept on receiving. (5.53 KB, patch)
2014-01-18 07:47 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 11141: Filters should be kept if the receive is cancelled (1.18 KB, patch)
2014-01-18 07:47 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-10-25 14:41:09 UTC
On receiving orders, the librarian has to filter again the pending orders list.
Comment 1 Jonathan Druart 2013-10-25 14:48:11 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-01-09 11:36:54 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-01-09 11:37:19 UTC
Last patch is just a rebase.
Comment 4 Biblibre Sandboxes 2014-01-10 09:33:14 UTC
Patch tested with a sandbox, by Nicolas Bravais <nicolas.bravais@gmail.com>
Comment 5 Biblibre Sandboxes 2014-01-10 09:33:36 UTC Comment hidden (obsolete)
Comment 6 nicolas 2014-01-10 10:04:19 UTC
Filters are still applied after receiving an item.
(tested with title, then basket, then author+basket)
Comment 7 Katrin Fischer 2014-01-14 20:10:05 UTC
Hi Jonathan,
I think I found a small problem: if you don't save, but go back with cancel, because you picked the wrong order, the filters are still lost. Could this be fixd as well?
Comment 8 Jonathan Druart 2014-01-15 09:16:25 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2014-01-15 09:17:19 UTC
(In reply to Katrin Fischer from comment #7)
> Hi Jonathan,
> I think I found a small problem: if you don't save, but go back with cancel,
> because you picked the wrong order, the filters are still lost. Could this
> be fixd as well?

Hi Katrin,
Yes it seems consistent. Last patch fixes that.
Comment 10 Katrin Fischer 2014-01-18 07:47:21 UTC
Created attachment 24536 [details] [review]
[PASSED QA] Bug 11141: Filters are not kept on receiving.

On receiving orders, the librarian has to filter again the pending
orders list.

This patch stores the filters in a cookie in order to apply them when
the librarian finish a receive and come back on the pending orders list.

Test plan:
1/ choose a vendor with several baskets and orders.
2/ start to receive an item.
3/ on the pending orders page, add some relevant filters.
4/ receive an item.
5/ you are back on the pending orders page and filters are directly
applied.

Signed-off-by: Nicolas Bravais <nicolas.bravais@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Tested with receiving and cancelling the receive process the
filters are kept.
Comment 11 Katrin Fischer 2014-01-18 07:47:37 UTC
Created attachment 24537 [details] [review]
[PASSED QA] Bug 11141: Filters should be kept if the receive is cancelled

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 12 Galen Charlton 2014-01-23 16:59:03 UTC
Pushed to master.  Thanks, Jonathan!
Comment 13 Jonathan Druart 2015-03-27 09:25:14 UTC
*** Bug 6741 has been marked as a duplicate of this bug. ***