Summary: | Labels::_guide_box should return undef if undefned data is passed | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 11402: Labels::_guide_box should return undef if undefned data is passed
Bug 11402: Labels::_guide_box should return undef if undefned data is passed [PASSED QA] Bug 11402: Labels::_guide_box should return undef if undefned data is passed |
Description
Tomás Cohen Arazi
2013-12-16 14:55:43 UTC
Created attachment 23577 [details] [review] Bug 11402: Labels::_guide_box should return undef if undefned data is passed That's it. A guide box cannot be created if invalid data is passed. Sponsored-by: Universidad Nacional de Cordoba Created attachment 23848 [details] [review] Bug 11402: Labels::_guide_box should return undef if undefned data is passed That's it. A guide box cannot be created if invalid data is passed. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 23857 [details] [review] [PASSED QA] Bug 11402: Labels::_guide_box should return undef if undefned data is passed That's it. A guide box cannot be created if invalid data is passed. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, includes new unit tests. Pushed to master, along with a follow-up that adds a unit test for the successful use of _guide_box(). Thanks, Tomás! Patches pushed to 3.14.x, will be in 3.14.3. This patch has been pushed to 3.12.x, will be in 3.12.11. |