Bug 11402 - Labels::_guide_box should return undef if undefned data is passed
Summary: Labels::_guide_box should return undef if undefned data is passed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-16 14:55 UTC by Tomás Cohen Arazi
Modified: 2015-12-03 22:00 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11402: Labels::_guide_box should return undef if undefned data is passed (2.33 KB, patch)
2013-12-16 14:58 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 11402: Labels::_guide_box should return undef if undefned data is passed (2.38 KB, patch)
2013-12-29 05:11 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11402: Labels::_guide_box should return undef if undefned data is passed (2.51 KB, patch)
2013-12-29 08:26 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2013-12-16 14:55:43 UTC

    
Comment 1 Tomás Cohen Arazi 2013-12-16 14:58:59 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-12-29 05:11:04 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-12-29 08:26:23 UTC
Created attachment 23857 [details] [review]
[PASSED QA] Bug 11402: Labels::_guide_box should return undef if undefned data is passed

That's it. A guide box cannot be created if invalid data is passed.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, includes new unit tests.
Comment 4 Galen Charlton 2013-12-30 16:24:18 UTC
Pushed to master, along with a follow-up that adds a unit test for the successful use of _guide_box().  Thanks, Tomás!
Comment 5 Fridolin Somers 2014-01-27 13:43:46 UTC
Patches pushed to 3.14.x, will be in 3.14.3.
Comment 6 Tomás Cohen Arazi 2014-02-07 17:10:45 UTC
This patch has been pushed to 3.12.x, will be in 3.12.11.