Summary: | Use new DataTables include in batch modification templates | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, katrin.fischer |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/tools/batchMod.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 11720 | ||
Attachments: |
Bug 11734 - Use new DataTables include in batch modification templates
Bug 11734 - Use new DataTables include in batch modification templates [SIGNED-OFF] Bug 11734 - Use new DataTables include in batch modification templates [PASSED QA] Bug 11734 - Use new DataTables include in batch modification templates |
Description
Owen Leonard
2014-02-10 17:26:35 UTC
Created attachment 25179 [details] [review] Bug 11734 - Use new DataTables include in batch modification templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch modification and batch deletion pages. Minor text changes: Corrected capitalization. Apply the patch and test the following: - On batch modification and batch deletion, submit multiple barcodes or item numbers. On the results page the title column has been configured to use the "anti-the" filter to exclude articles from sorting. Sorting on all columns should work correctly. Created attachment 25734 [details] [review] Bug 11734 - Use new DataTables include in batch modification templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch modification and batch deletion pages. Minor text changes: Corrected capitalization. Apply the patch and test the following: - On batch modification and batch deletion, submit multiple barcodes or item numbers. On the results page the title column has been configured to use the "anti-the" filter to exclude articles from sorting. Sorting on all columns should work correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Hi Owen, sorry, seems no luck today, I found something with this patch as well. I tested the batch delete tables without any problems, looks all good. Then I tested the batch modify from the same record, my column selection was remembered. But there is a Javascript error when I click on the Show all columns/Hide all columns and Clear all/Select all links: TypeError: $(...).checkCheckboxes is not a function $("#selections").checkCheckboxes(); I tried reloading the Javascript multiple times. Created attachment 26425 [details] [review] [SIGNED-OFF] Bug 11734 - Use new DataTables include in batch modification templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch modification and batch deletion pages. Minor text changes: Corrected capitalization. Apply the patch and test the following: - On batch modification and batch deletion, submit multiple barcodes or item numbers. On the results page the title column has been configured to use the "anti-the" filter to exclude articles from sorting. Sorting on all columns should work correctly. Edit: Put back checkboxes plugin which was accidentally removed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 26432 [details] [review] [PASSED QA] Bug 11734 - Use new DataTables include in batch modification templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch modification and batch deletion pages. Minor text changes: Corrected capitalization. Apply the patch and test the following: - On batch modification and batch deletion, submit multiple barcodes or item numbers. On the results page the title column has been configured to use the "anti-the" filter to exclude articles from sorting. Sorting on all columns should work correctly. Edit: Put back checkboxes plugin which was accidentally removed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.10 |