Bug 11734 - Use new DataTables include in batch modification templates
Summary: Use new DataTables include in batch modification templates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/tools/batchMod.pl
Keywords:
Depends on:
Blocks: 11720
  Show dependency treegraph
 
Reported: 2014-02-10 17:26 UTC by Owen Leonard
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11734 - Use new DataTables include in batch modification templates (6.62 KB, patch)
2014-02-10 17:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11734 - Use new DataTables include in batch modification templates (6.63 KB, patch)
2014-02-28 17:04 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11734 - Use new DataTables include in batch modification templates (6.83 KB, patch)
2014-03-17 19:07 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 11734 - Use new DataTables include in batch modification templates (6.93 KB, patch)
2014-03-18 07:22 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-10 17:26:35 UTC
The batch modification and batch deletion templates should be updated to use the new DataTables include file introduced by Bug 10649.
Comment 1 Owen Leonard 2014-02-10 17:32:23 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-02-28 17:04:24 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-16 19:01:55 UTC
Hi Owen, sorry, seems no luck today, I found something with this patch as well. I tested the batch delete tables without any problems, looks all good. Then I tested the batch modify from the same record, my column selection was remembered. But there is a Javascript error when I click on the Show all columns/Hide all columns and Clear all/Select all links:

TypeError: $(...).checkCheckboxes is not a function
$("#selections").checkCheckboxes();

I tried reloading the Javascript multiple times.
Comment 4 Owen Leonard 2014-03-17 19:07:10 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-03-18 07:22:19 UTC
Created attachment 26432 [details] [review]
[PASSED QA] Bug 11734 - Use new DataTables include in batch modification templates

Bug 10649 introduced a new include file for adding DataTables-related
JavaScript assets. This patch adds use of this include file to the
batch modification and batch deletion pages.

Minor text changes: Corrected capitalization.

Apply the patch and test the following:

- On batch modification and batch deletion, submit multiple barcodes or
  item numbers. On the results page the title column has been configured
  to use the "anti-the" filter to exclude articles from sorting. Sorting
  on all columns should work correctly.

Edit: Put back checkboxes plugin which was accidentally removed.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.
Comment 6 Galen Charlton 2014-04-08 23:52:01 UTC
Pushed to master.  Thanks, Owen!
Comment 7 Fridolin Somers 2014-08-01 13:43:49 UTC
Pushed to 3.14.x, will be in 3.14.10