Bug 11737

Summary: Use new DataTables include in quotes management template
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, gmcharlt, sandboxes
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/tools/quotes.pl
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 11720    
Attachments: Bug 11737 - Use new DataTables include in quotes management template
Bug 11737 - Use new DataTables include in quotes management template
Bug 11737 - Use new DataTables include in quotes management template
Bug 11737: (follow-up) fnReloadAjax.js is duplicated

Description Owen Leonard 2014-02-10 19:28:12 UTC
The quotes management template should be updated to use the new DataTables include file introduced by Bug 10649.
Comment 1 Owen Leonard 2014-02-10 19:35:32 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2014-02-11 03:15:15 UTC
Patch tested with a sandbox, by merlissia <manuelimel@gmail.com>
Comment 3 Biblibre Sandboxes 2014-02-11 03:15:34 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-02-11 09:31:55 UTC
Created attachment 25192 [details] [review]
Bug 11737 - Use new DataTables include in quotes management template

Bug 10649 introduced a new include file for adding DataTables-related
JavaScript assets. This patch adds use of this include file to the
quotes management page.

To test you should have a multiple quotes in your database. Apply the
patch and view the quotes manager page (tools/quotes.pl). Confirm that
table sorting works correctly.

Signed-off-by: merlissia <manuelimel@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2014-02-11 09:32:13 UTC
Created attachment 25193 [details] [review]
Bug 11737: (follow-up) fnReloadAjax.js is duplicated

the file dataTables.fnReloadAjax.js exists in the interface and
themelang directories.
It is only used in quotes.tt.
So the unused one can be removed.

test plan:
git grep fnReloadAjax.js
should return only 1 ref (quotes.tt)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Galen Charlton 2014-02-13 03:17:57 UTC
Pushed to master.  Thanks, Owen!
Comment 7 Fridolin Somers 2014-05-19 13:59:23 UTC
Pushed to 3.14.x, will be in 3.14.07.