Bug 11737 - Use new DataTables include in quotes management template
Summary: Use new DataTables include in quotes management template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/tools/quotes.pl
Keywords:
Depends on:
Blocks: 11720
  Show dependency tree / graph
 
Reported: 2014-02-10 19:28 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11737 - Use new DataTables include in quotes management template (2.06 KB, patch)
2014-02-10 19:35 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 11737 - Use new DataTables include in quotes management template (2.06 KB, patch)
2014-02-11 03:15 UTC, Biblibre Sandboxes 		Details | Diff | Splinter Review
Bug 11737 - Use new DataTables include in quotes management template (2.13 KB, patch)
2014-02-11 09:31 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 11737: (follow-up) fnReloadAjax.js is duplicated (2.70 KB, patch)
2014-02-11 09:32 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-10 19:28:12 UTC 
The quotes management template should be updated to use the new DataTables include file introduced by Bug 10649.
Comment 1 Owen Leonard 2014-02-10 19:35:32 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2014-02-11 03:15:15 UTC 
Patch tested with a sandbox, by merlissia <manuelimel@gmail.com>
Comment 3 Biblibre Sandboxes 2014-02-11 03:15:34 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-02-11 09:31:55 UTC 
Created attachment 25192 [details] [review]
Bug 11737 - Use new DataTables include in quotes management template

Bug 10649 introduced a new include file for adding DataTables-related
JavaScript assets. This patch adds use of this include file to the
quotes management page.

To test you should have a multiple quotes in your database. Apply the
patch and view the quotes manager page (tools/quotes.pl). Confirm that
table sorting works correctly.

Signed-off-by: merlissia <manuelimel@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2014-02-11 09:32:13 UTC 
Created attachment 25193 [details] [review]
Bug 11737: (follow-up) fnReloadAjax.js is duplicated

the file dataTables.fnReloadAjax.js exists in the interface and
themelang directories.
It is only used in quotes.tt.
So the unused one can be removed.

test plan:
git grep fnReloadAjax.js
should return only 1 ref (quotes.tt)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Galen Charlton 2014-02-13 03:17:57 UTC 
Pushed to master.  Thanks, Owen!
Comment 7 Fridolin Somers 2014-05-19 13:59:23 UTC 
Pushed to 3.14.x, will be in 3.14.07.