Bug 11806

Summary: Use validation plugin when creating new OAI set
Product: Koha Reporter: Owen Leonard <oleonard>
Component: System AdministrationAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, katrin.fischer, veron
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/admin/oai_sets.pl?op=new
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 11806 - Use validation plugin when creating new OAI set
[Signed-off] Bug 11806 - Use validation plugin when creating new OAI set
[PASSED QA] Bug 11806 - Use validation plugin when creating new OAI set

Description Owen Leonard 2014-02-20 21:06:37 UTC
The new OAI set entry form shows that two fields are required but does not enforce this requirement. This can be handled client-side with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/).
Comment 1 Owen Leonard 2014-02-20 21:11:47 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-03-06 15:38:21 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-16 13:53:48 UTC
Created attachment 26376 [details] [review]
[PASSED QA] Bug 11806 - Use validation plugin when creating new OAI set

The form for adding a new OAI indicates that two fields are
required but does nothing to enforce this rule. This can be
handled client-side with HTML5 validation attributes and Koha's built-in
validation plugin. This patch implements this.

To test, apply the patch and go to Administration -> OAI sets
configuration -> New set. Try submitting the form without entering a
setSpec and/or setName. Doing so should trigger a validation warning.

Submission of the form with valid data should work correctly. Editing an
existing set should also work correctly.

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, works as described.
Comment 4 Galen Charlton 2014-03-26 19:22:12 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-06-18 15:36:03 UTC
Pushed to 3.14.x, will be in 3.14.08