Bug 11806 - Use validation plugin when creating new OAI set
Summary: Use validation plugin when creating new OAI set
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/oai_sets.pl?op=new
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-20 21:06 UTC by Owen Leonard
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11806 - Use validation plugin when creating new OAI set (2.68 KB, patch)
2014-02-20 21:11 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 11806 - Use validation plugin when creating new OAI set (2.84 KB, patch)
2014-03-06 15:38 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 11806 - Use validation plugin when creating new OAI set (2.94 KB, patch)
2014-03-16 13:53 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-20 21:06:37 UTC
The new OAI set entry form shows that two fields are required but does not enforce this requirement. This can be handled client-side with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/).
Comment 1 Owen Leonard 2014-02-20 21:11:47 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-03-06 15:38:21 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-16 13:53:48 UTC
Created attachment 26376 [details] [review]
[PASSED QA] Bug 11806 - Use validation plugin when creating new OAI set

The form for adding a new OAI indicates that two fields are
required but does nothing to enforce this rule. This can be
handled client-side with HTML5 validation attributes and Koha's built-in
validation plugin. This patch implements this.

To test, apply the patch and go to Administration -> OAI sets
configuration -> New set. Try submitting the form without entering a
setSpec and/or setName. Doing so should trigger a validation warning.

Submission of the form with valid data should work correctly. Editing an
existing set should also work correctly.

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, works as described.
Comment 4 Galen Charlton 2014-03-26 19:22:12 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-06-18 15:36:03 UTC
Pushed to 3.14.x, will be in 3.14.08