Bug 11914

Summary: Ordering from suggestions: fund (budget id) is not retained; price calculations not working
Product: Koha Reporter: Jacek Ablewicz <abl>
Component: AcquisitionsAssignee: Jacek Ablewicz <abl>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P1 - high CC: fridolin.somers, gmcharlt
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working
Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working
[PASSED QA] Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working

Description Jacek Ablewicz 2014-03-10 09:36:15 UTC
When order is being created from purchase suggestion:

- Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage.
- If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g, quantity or vendor price).
Comment 1 Jacek Ablewicz 2014-03-10 10:07:29 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-03-10 20:46:26 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-23 20:09:28 UTC
Created attachment 26525 [details] [review]
[PASSED QA] Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working

When order is being created from purchase suggestion:
- Budget/fund stored in suggestion record (if any) is not retained
on order page, system always defaults to 'Select a fund' even if some
fund was already chosen for a suggestion on the earlier stage.
- If there was a price given to, and stored within suggestion record,
initial prices calculations on order page are not working properly
('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank).
As a workaround - to force correct price recalculation - user needs
to manually alter and then re-alter some price-related fields (e.g.,
quantity or vendor price).

This patch fixes both issues.

Test plan:
1) create a suggestion: choose some buget, enter something in 'Price'
and 'Quantity' fields,
2) try to make an order from this suggestion, to confirm/replicate
aforementioned problems,
3) apply patch,
4) make an order from previously created suggestion again, observe
that both issues are now resolved.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.
Comment 4 Galen Charlton 2014-04-18 22:00:37 UTC
Pushed to master.  Thanks, Jacek!
Comment 5 Fridolin Somers 2014-08-06 10:53:24 UTC
Pushed to 3.14.x, will be in 3.14.10