Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working
Summary: Ordering from suggestions: fund (budget id) is not retained; price calculatio...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P1 - high normal (vote)
Assignee: Jacek Ablewicz
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-10 09:36 UTC by Jacek Ablewicz
Modified: 2015-06-04 23:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working (2.44 KB, patch)
2014-03-10 10:07 UTC, Jacek Ablewicz
Details | Diff | Splinter Review
Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working (2.48 KB, patch)
2014-03-10 20:46 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working (2.60 KB, patch)
2014-03-23 20:09 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Ablewicz 2014-03-10 09:36:15 UTC
When order is being created from purchase suggestion:

- Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage.
- If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g, quantity or vendor price).
Comment 1 Jacek Ablewicz 2014-03-10 10:07:29 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-03-10 20:46:26 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-23 20:09:28 UTC
Created attachment 26525 [details] [review]
[PASSED QA] Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working

When order is being created from purchase suggestion:
- Budget/fund stored in suggestion record (if any) is not retained
on order page, system always defaults to 'Select a fund' even if some
fund was already chosen for a suggestion on the earlier stage.
- If there was a price given to, and stored within suggestion record,
initial prices calculations on order page are not working properly
('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank).
As a workaround - to force correct price recalculation - user needs
to manually alter and then re-alter some price-related fields (e.g.,
quantity or vendor price).

This patch fixes both issues.

Test plan:
1) create a suggestion: choose some buget, enter something in 'Price'
and 'Quantity' fields,
2) try to make an order from this suggestion, to confirm/replicate
aforementioned problems,
3) apply patch,
4) make an order from previously created suggestion again, observe
that both issues are now resolved.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.
Comment 4 Galen Charlton 2014-04-18 22:00:37 UTC
Pushed to master.  Thanks, Jacek!
Comment 5 Fridolin Somers 2014-08-06 10:53:24 UTC
Pushed to 3.14.x, will be in 3.14.10