Summary: | Follow up fix for tools/inventory.pl's output_pref issues | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Tools | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 12115 - Follow up fix for tools/inventory's output_pref issues
Bug 12115 - Follow up fix for tools/inventory's output_pref issues [PASSED QA] Bug 12115 - Follow up fix for tools/inventory's output_pref issues |
Description
Mark Tompsett
2014-04-21 14:28:07 UTC
Created attachment 27352 [details] [review] Bug 12115 - Follow up fix for tools/inventory's output_pref issues This should correct issues with the output_prefs in the compareinv2bar logic section of tools/inventory.pl It is a follow up to bug 11253. TEST PLAN --------- NOTE: There should be no distinguishable difference before and after the patch. This corrects a works by accident bug. Back up DB. Create a small barcode file from books in a given branch. Set I18N/L10N system preference of dateformat to mm/dd/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in mm/dd/yyyy format. Set I18N/L10N system preference of dateformat to yyyy-mm-dd. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in yyyy-mm-dd format. Set I18N/L10N system preference of dateformat to dd/mm/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in dd/mm/yyyy format. Apply patch Restore DB (so results should be comparable to the first result) Repeat the three testing blocks above. There should be no visible difference. Created attachment 27519 [details] [review] Bug 12115 - Follow up fix for tools/inventory's output_pref issues This should correct issues with the output_prefs in the compareinv2bar logic section of tools/inventory.pl It is a follow up to bug 11253. TEST PLAN --------- NOTE: There should be no distinguishable difference before and after the patch. This corrects a works by accident bug. Back up DB. Create a small barcode file from books in a given branch. Set I18N/L10N system preference of dateformat to mm/dd/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in mm/dd/yyyy format. Set I18N/L10N system preference of dateformat to yyyy-mm-dd. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in yyyy-mm-dd format. Set I18N/L10N system preference of dateformat to dd/mm/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in dd/mm/yyyy format. Apply patch Restore DB (so results should be comparable to the first result) Repeat the three testing blocks above. There should be no visible difference. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 27617 [details] [review] [PASSED QA] Bug 12115 - Follow up fix for tools/inventory's output_pref issues This should correct issues with the output_prefs in the compareinv2bar logic section of tools/inventory.pl It is a follow up to bug 11253. TEST PLAN --------- NOTE: There should be no distinguishable difference before and after the patch. This corrects a works by accident bug. Back up DB. Create a small barcode file from books in a given branch. Set I18N/L10N system preference of dateformat to mm/dd/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in mm/dd/yyyy format. Set I18N/L10N system preference of dateformat to yyyy-mm-dd. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in yyyy-mm-dd format. Set I18N/L10N system preference of dateformat to dd/mm/yyyy. Go to inventory/stocktaking tool. Browse for the barcode file. Click submit just below the 'Use a barcode file' section. All looks fine in dd/mm/yyyy format. Apply patch Restore DB (so results should be comparable to the first result) Repeat the three testing blocks above. There should be no visible difference. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Mark! Pushed to 3.14.x, will be in 3.14.07 |