Bug 12115 - Follow up fix for tools/inventory.pl's output_pref issues
Summary: Follow up fix for tools/inventory.pl's output_pref issues
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-21 14:28 UTC by Mark Tompsett
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12115 - Follow up fix for tools/inventory's output_pref issues (2.46 KB, patch)
2014-04-21 15:57 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 12115 - Follow up fix for tools/inventory's output_pref issues (2.56 KB, patch)
2014-04-24 07:20 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[PASSED QA] Bug 12115 - Follow up fix for tools/inventory's output_pref issues (2.59 KB, patch)
2014-04-25 12:41 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2014-04-21 14:28:07 UTC
In bug 11253, the second parameter was ignore, and caused issues for dd/mm/yyyy. However, two other lines later in the code were broken, but worked by accident. This is to patch those two lines.
Comment 1 Mark Tompsett 2014-04-21 15:57:19 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2014-04-24 07:20:07 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-04-25 12:41:38 UTC
Created attachment 27617 [details] [review]
[PASSED QA] Bug 12115 - Follow up fix for tools/inventory's output_pref issues

This should correct issues with the output_prefs in the
compareinv2bar logic section of tools/inventory.pl
It is a follow up to bug 11253.

TEST PLAN
---------
NOTE: There should be no distinguishable difference before and
      after the patch. This corrects a works by accident bug.

Back up DB.
Create a small barcode file from books in a given branch.

Set I18N/L10N system preference of dateformat to mm/dd/yyyy.
Go to inventory/stocktaking tool.
Browse for the barcode file.
Click submit just below the 'Use a barcode file' section.
All looks fine in mm/dd/yyyy format.

Set I18N/L10N system preference of dateformat to yyyy-mm-dd.
Go to inventory/stocktaking tool.
Browse for the barcode file.
Click submit just below the 'Use a barcode file' section.
All looks fine in yyyy-mm-dd format.

Set I18N/L10N system preference of dateformat to dd/mm/yyyy.
Go to inventory/stocktaking tool.
Browse for the barcode file.
Click submit just below the 'Use a barcode file' section.
All looks fine in dd/mm/yyyy format.

Apply patch
Restore DB (so results should be comparable to the first result)
Repeat the three testing blocks above.
There should be no visible difference.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2014-04-28 16:33:50 UTC
Pushed to master.  Thanks, Mark!
Comment 5 Fridolin Somers 2014-05-27 14:01:14 UTC
Pushed to 3.14.x, will be in 3.14.07