Bug 12163

Summary: Adding a new quote fails
Product: Koha Reporter: Robin Sheat <robin>
Component: ToolsAssignee: Robin Sheat <robin>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 9048    
Attachments: Bug 12163 - fix adding new quotes
Bug 12163 - fix adding new quotes

Description Robin Sheat 2014-04-30 04:27:56 UTC
Adding a new quote doesn't work right, as there is an error in the javascript to re-draw the table row.

Everything actually works, but it appears to the user as though nothing is happening.
Comment 1 Robin Sheat 2014-04-30 04:31:32 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-04-30 15:45:37 UTC
Created attachment 27819 [details] [review]
Bug 12163 - fix adding new quotes

Something changed somewhere (maybe a new jQuery or datatables version)
and the javascript that redrew the table row after a new quote was saved
stopped working. This fixes the call to the datatables function so that
it matches the API.

To test:
* Go and add a quote.
* Note that when you press enter after finishing the quote, the line
  stops being an editor, and becomes just a display, like it should.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Galen Charlton 2014-05-06 16:04:53 UTC
Taking the liberty of pushing this to master because of the regression.  Thanks, Robin!