Bug 12163 - Adding a new quote fails
Summary: Adding a new quote fails
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Robin Sheat
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 9048
  Show dependency treegraph
 
Reported: 2014-04-30 04:27 UTC by Robin Sheat
Modified: 2014-12-07 20:07 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12163 - fix adding new quotes (1.34 KB, patch)
2014-04-30 04:31 UTC, Robin Sheat
Details | Diff | Splinter Review
Bug 12163 - fix adding new quotes (1.41 KB, patch)
2014-04-30 15:45 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2014-04-30 04:27:56 UTC
Adding a new quote doesn't work right, as there is an error in the javascript to re-draw the table row.

Everything actually works, but it appears to the user as though nothing is happening.
Comment 1 Robin Sheat 2014-04-30 04:31:32 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-04-30 15:45:37 UTC
Created attachment 27819 [details] [review]
Bug 12163 - fix adding new quotes

Something changed somewhere (maybe a new jQuery or datatables version)
and the javascript that redrew the table row after a new quote was saved
stopped working. This fixes the call to the datatables function so that
it matches the API.

To test:
* Go and add a quote.
* Note that when you press enter after finishing the quote, the line
  stops being an editor, and becomes just a display, like it should.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Galen Charlton 2014-05-06 16:04:53 UTC
Taking the liberty of pushing this to master because of the regression.  Thanks, Robin!