Bug 12269

Summary: Multiple definitions of adult borrower
Product: Koha Reporter: paxed <pasi.kallinen>
Component: PatronsAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, katrin.fischer, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description paxed 2014-05-16 05:57:04 UTC
rgrep adultborrower * | grep -v ^blib shows:

circ/circulation.pl:    $template->param( adultborrower => 1 ) if ( $borrower->{'category_type'} eq 'A' );
members/boraccount.pl:$template->param( adultborrower => 1 ) if ( $data->{'category_type'} eq 'A' );
members/moremember.pl:    ( $template->param( adultborrower => 1 ) ) if ( $category_type eq 'A' || $category_type eq 'I' );
members/printfeercpt.pl:$template->param( adultborrower => 1 ) if ( $data->{'category_type'} eq 'A' );

etc. in several more places.

There really should be a single function for this, or inconsistencies will creep in - note the 'A' or 'I' in moremember!
Comment 1 Katrin Fischer 2019-02-04 22:14:12 UTC
I can't find any mention of "adultborrower" in the codebase anymore. It appears that this has been cleaned up:

Koha/Patron.pm:my $is_adult = $patron->is_adult