Bug 12269 - Multiple definitions of adult borrower
Summary: Multiple definitions of adult borrower
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-16 05:57 UTC by paxed
Modified: 2020-01-06 20:14 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-05-16 05:57:04 UTC
rgrep adultborrower * | grep -v ^blib shows:

circ/circulation.pl:    $template->param( adultborrower => 1 ) if ( $borrower->{'category_type'} eq 'A' );
members/boraccount.pl:$template->param( adultborrower => 1 ) if ( $data->{'category_type'} eq 'A' );
members/moremember.pl:    ( $template->param( adultborrower => 1 ) ) if ( $category_type eq 'A' || $category_type eq 'I' );
members/printfeercpt.pl:$template->param( adultborrower => 1 ) if ( $data->{'category_type'} eq 'A' );

etc. in several more places.

There really should be a single function for this, or inconsistencies will creep in - note the 'A' or 'I' in moremember!
Comment 1 Katrin Fischer 2019-02-04 22:14:12 UTC
I can't find any mention of "adultborrower" in the codebase anymore. It appears that this has been cleaned up:

Koha/Patron.pm:my $is_adult = $patron->is_adult