Bug 12572

Summary: Use jQueryUI Accordion to display message transport types
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: nengard, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 12572 - Use jQueryUI Accordion to display message transport types
[SIGNED OFF] Bug 12572 - Use jQueryUI Accordion to display message transport types
Bug 12572 - Use jQueryUI Accordion to display message transport types
Bug 12572: The first tab should be open by default

Description Owen Leonard 2014-07-14 14:31:50 UTC
When editing a notice the various message transport type settings could be grouped in a jQueryUI accordion to make the editing view a little simpler.
Comment 1 Owen Leonard 2014-07-14 14:45:03 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-07-15 15:43:25 UTC
*** Bug 12232 has been marked as a duplicate of this bug. ***
Comment 3 Katrin Fischer 2014-07-20 21:32:11 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-07-21 10:20:57 UTC
Created attachment 29919 [details] [review]
Bug 12572 - Use jQueryUI Accordion to display message transport types

The notice edit view has separate sections for each of the various
message transport types. This patch groups them in a jQueryUI accordion
to simplify the view.

Also changed: Some label/id pairs have been changed to eliminate
duplicate ids.

To test, apply the patch an edit any notice under Tools -> Notices &
Slips.

- The message transport type fields for email, feed, phone, etc. should
  be correctly grouped in a collapsed accordion. The acccordion should
  look correct and work correctly.
- Clicking the label for any form field should correctly highlight the
  corresponding field.
- Submitting updates to the notice should work correctly for all message
  transport types.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This works as described.
Something small: the top border of the uncollapsed/opened section
doesn't display correctly, but this is working a lot nicer than before,
as now changing a message requires a lot less scrolling.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2014-07-21 10:21:17 UTC Comment hidden (obsolete)
Comment 6 Tomás Cohen Arazi 2014-07-21 14:15:07 UTC
Comment on attachment 29920 [details] [review]
Bug 12572: The first tab should be open by default

There are several uses where expanding Email doesn't make sense.
Comment 7 Tomás Cohen Arazi 2014-07-25 21:59:50 UTC
Patch pushed to master.

Thanks Owen!