When editing a notice the various message transport type settings could be grouped in a jQueryUI accordion to make the editing view a little simpler.
Created attachment 29680 [details] [review] Bug 12572 - Use jQueryUI Accordion to display message transport types The notice edit view has separate sections for each of the various message transport types. This patch groups them in a jQueryUI accordion to simplify the view. Also changed: Some label/id pairs have been changed to eliminate duplicate ids. To test, apply the patch an edit any notice under Tools -> Notices & Slips. - The message transport type fields for email, feed, phone, etc. should be correctly grouped in a collapsed accordion. The acccordion should look correct and work correctly. - Clicking the label for any form field should correctly highlight the corresponding field. - Submitting updates to the notice should work correctly for all message transport types.
*** Bug 12232 has been marked as a duplicate of this bug. ***
Created attachment 29896 [details] [review] [SIGNED OFF] Bug 12572 - Use jQueryUI Accordion to display message transport types The notice edit view has separate sections for each of the various message transport types. This patch groups them in a jQueryUI accordion to simplify the view. Also changed: Some label/id pairs have been changed to eliminate duplicate ids. To test, apply the patch an edit any notice under Tools -> Notices & Slips. - The message transport type fields for email, feed, phone, etc. should be correctly grouped in a collapsed accordion. The acccordion should look correct and work correctly. - Clicking the label for any form field should correctly highlight the corresponding field. - Submitting updates to the notice should work correctly for all message transport types. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as subscripted. Something small: the top border of the uncollapsed/opened section doesn't display correctly, but this is working a lot nicer than before, as now changing a message requires a lot less scrolling.
Created attachment 29919 [details] [review] Bug 12572 - Use jQueryUI Accordion to display message transport types The notice edit view has separate sections for each of the various message transport types. This patch groups them in a jQueryUI accordion to simplify the view. Also changed: Some label/id pairs have been changed to eliminate duplicate ids. To test, apply the patch an edit any notice under Tools -> Notices & Slips. - The message transport type fields for email, feed, phone, etc. should be correctly grouped in a collapsed accordion. The acccordion should look correct and work correctly. - Clicking the label for any form field should correctly highlight the corresponding field. - Submitting updates to the notice should work correctly for all message transport types. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as described. Something small: the top border of the uncollapsed/opened section doesn't display correctly, but this is working a lot nicer than before, as now changing a message requires a lot less scrolling. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 29920 [details] [review] Bug 12572: The first tab should be open by default To avoid an extra click, the first tab (email) should be open by default. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment on attachment 29920 [details] [review] Bug 12572: The first tab should be open by default There are several uses where expanding Email doesn't make sense.
Patch pushed to master. Thanks Owen!