Bug 12612

Summary: Remove CGI::scrolling_list from auth_tag_structure.pl
Product: Koha Reporter: Bernardo Gonzalez Kriegel <bgkriegel>
Component: TemplatesAssignee: Bernardo Gonzalez Kriegel <bgkriegel>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 766    
Attachments: Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl
Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl
[PASSED QA] Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl

Description Bernardo Gonzalez Kriegel 2014-07-19 17:46:09 UTC
We need to remove all of them.
New related Bug as requested by RM.
Comment 1 Bernardo Gonzalez Kriegel 2014-07-19 17:52:04 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-07-25 14:46:49 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-07-28 21:17:32 UTC
Created attachment 30235 [details] [review]
[PASSED QA] Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl

This patch removes the only instance in this file.

Don't know if the feature is of some utility, seems
that does not work (no use of auth values as indicators
on MARC authority editor)

To test:
1. Apply the patch
2. Go to Administration > Authority types
3. Clic on MARC structure of any fw
4. Clic Edit on any tag
5. On tag editor check the pulldown 'Authorised value', that was replaced
6. Check for regressions: select a value, save, verify the value, change
again, etc.

Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as expected, no regressions found.
Comment 4 Tomás Cohen Arazi 2014-07-29 14:50:17 UTC
Patch pushed to master.

Thanks Bernardo!