Bug 12612 - Remove CGI::scrolling_list from auth_tag_structure.pl
Summary: Remove CGI::scrolling_list from auth_tag_structure.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 766
  Show dependency treegraph
 
Reported: 2014-07-19 17:46 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl (3.83 KB, patch)
2014-07-19 17:52 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl (3.90 KB, patch)
2014-07-25 14:46 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl (4.00 KB, patch)
2014-07-28 21:17 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2014-07-19 17:46:09 UTC
We need to remove all of them.
New related Bug as requested by RM.
Comment 1 Bernardo Gonzalez Kriegel 2014-07-19 17:52:04 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-07-25 14:46:49 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-07-28 21:17:32 UTC
Created attachment 30235 [details] [review]
[PASSED QA] Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl

This patch removes the only instance in this file.

Don't know if the feature is of some utility, seems
that does not work (no use of auth values as indicators
on MARC authority editor)

To test:
1. Apply the patch
2. Go to Administration > Authority types
3. Clic on MARC structure of any fw
4. Clic Edit on any tag
5. On tag editor check the pulldown 'Authorised value', that was replaced
6. Check for regressions: select a value, save, verify the value, change
again, etc.

Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as expected, no regressions found.
Comment 4 Tomás Cohen Arazi 2014-07-29 14:50:17 UTC
Patch pushed to master.

Thanks Bernardo!