Summary: | Stray dollar ($) -sign in opac-reserve.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
Component: | OPAC | Assignee: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, katrin.fischer, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl
[Signed-off] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl [PASSED QA] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl |
Description
Olli-Antti Kivilahti
2014-07-29 09:02:29 UTC
*** Bug 12667 has been marked as a duplicate of this bug. *** Created attachment 30267 [details] [review] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation when one has "too_much_oweing" or too much fines. Removing the dollar sign so we just get <"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja 9.50."> instead of <"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja $9.50."> Created attachment 30361 [details] [review] [Signed-off] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation when one has "too_much_oweing" or too much fines. Removing the dollar sign so we just get <"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja 9.50."> instead of <"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja $9.50."> Patch removes hard coded $ sign. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 30372 [details] [review] [PASSED QA] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation when one has "too_much_oweing" or too much fines. Removing the dollar sign so we just get <"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja 9.50."> instead of <"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja $9.50."> Patch removes hard coded $ sign. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The dollar sign is gone and the message still displays correctly. Patch pushed to master. Thanks Olli! No, thank you for testing this! And thank my boss who found it ;) Pushed to 3.16.x for inclusion in 3.16.3. |