Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl
Summary: Stray dollar ($) -sign in opac-reserve.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
: 12667 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-29 09:02 UTC by Olli-Antti Kivilahti
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl (1.44 KB, patch)
2014-07-29 09:26 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
[Signed-off] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl (1.54 KB, patch)
2014-07-30 22:01 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl (1.65 KB, patch)
2014-07-31 06:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2014-07-29 09:02:29 UTC
A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation when one has "too_much_oweing" or too much fines.

Removing the dollar sign so we just get

<"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja 9.50.">

instead of 

<"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja $9.50.">
Comment 1 Olli-Antti Kivilahti 2014-07-29 09:03:01 UTC
*** Bug 12667 has been marked as a duplicate of this bug. ***
Comment 2 Olli-Antti Kivilahti 2014-07-29 09:26:32 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2014-07-30 22:01:32 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-07-31 06:10:33 UTC
Created attachment 30372 [details] [review]
[PASSED QA] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl

A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation
 when one has "too_much_oweing" or too much fines.

Removing the dollar sign so we just get

<"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja 9.50.">

instead of

<"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja $9.50.">

Patch removes hard coded $ sign.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
The dollar sign is gone and the message still displays correctly.
Comment 5 Tomás Cohen Arazi 2014-08-03 20:36:01 UTC
Patch pushed to master.

Thanks Olli!
Comment 6 Olli-Antti Kivilahti 2014-08-04 13:28:40 UTC
No, thank you for testing this!
And thank my boss who found it ;)
Comment 7 Galen Charlton 2014-08-26 22:46:53 UTC
Pushed to 3.16.x for inclusion in 3.16.3.